[asterisk-bugs] [JIRA] (ASTERISK-24601) [patch]Missing RFC4235 tags and attributes in PJSIP NOTIFY event: dialog XML body

[Marco Styner (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=246995#comment-246995 ] 

Marco Styner commented on ASTERISK-24601:
-----------------------------------------

Is there any way to have this fixed somehow....? We are using Asterisk/FreePBX for a not-for-profit organization. The lack of the proper implementation of SIP notify makes it impossible to use a Snom phone as the "switchboard" phone in a sensible fashion (ie. it is important for us to see who is calling to another extension and to react to it).

I am just surprised that there are not many more people in need for this to work.....

We are willing to sponsor some of the work if this helps to get things moving ;-)

> [patch]Missing RFC4235 tags and attributes in PJSIP NOTIFY event: dialog  XML body
> ----------------------------------------------------------------------------------
>
>                 Key: ASTERISK-24601
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24601
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: pjproject/pjsip
>    Affects Versions: SVN, 13.1.0, 13.2.0
>         Environment: debian
>            Reporter: Marco Paland
>              Labels: patch
>         Attachments: direction_recipient.patch, extensions.conf, pjsip.conf, pjsip_dialog_info_direction.patch
>
>
> I'm having a similar MAJOR issue, which makes 13.0.0 unusable with snom phones.
> We are using the PJSIP stack, not the chan_sip.
> The NOTIFY header (at ext 1010) of a ringing extension (1005) looks like:
> {code}
> <--- Transmitting SIP request (808 bytes) to UDP:192.168.1.155:36578 --->
> NOTIFY sip:1010 at 192.168.1.155:36578 SIP/2.0
> Via: SIP/2.0/UDP 192.168.1.1:5060;rport;branch=z9hG4bKPjbaab25f1-9a22-4e9d-95f0-0311eba3d937
> From: <sip:1005 at 192.168.1.1>;tag=94d2b042-dfe5-4d56-bc1b-77b212dd4d0f
> To: <sip:1010 at 192.168.1.1>;tag=54wyd8hmq4
> Contact: <sip:192.168.1.1:5060>
> Call-ID: 313431373934373935333433383134-n1tmcldgl41x
> CSeq: 25798 NOTIFY
> Event: dialog
> Subscription-State: active;expires=3500
> Allow-Events: message-summary, presence, dialog, refer
> Max-Forwards: 70
> User-Agent: Asterisk
> Content-Type: application/dialog-info+xml
> Content-Length: 228
> <?xml version="1.0" encoding="UTF-8"?>
> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="1" state="full" entity="sip:1005 at 200.200.200.200:5060">
>  <dialog id="1005">
>   <state>early</state>
>  </dialog>
> </dialog-info>
> {code}
> Issues:
> - <remote> and <local> tags of the dialog are missing completely
> - No (IMPORTANT) direction="recipient" attribute in <dialog> tag
> - entity="sip:1005 at 200.200.200.200:5060" is outside IP, but inside IP (192.168.1.1) is needed
> I had a short look in the actual res_pjsip_dialog_info_body_generator.c code and it seems that the first two points are missing.
> In 11.9.0 with chan_sip the NOTIFY dialog body looked like:
> {code}
> <?xml version="1.0"?>
> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="400" state="full" entity="sip:1001 at 192.168.1.1">
>   <dialog id="1001" call-id="pickup-313431373935383030383437363430-nfo981jwg9s8" local-tag="79zeqhuwdv" remote-tag="as6fb48de2" direction="recipient">
>     <remote>
>       <identity display="0174333">sip:0174333 at 192.168.1.1</identity>
>       <target uri="sip:0174333 at 192.168.1.1"/>
>     </remote>
>     <local>
>       <identity display="Counter">sip:1001 at 192.168.1.1</identity>
>       <target uri="sip:1001 at 192.168.1.1"/>
>     </local>
>     <state>early</state>
>   </dialog>
> </dialog-info>
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)