[asterisk-bugs] [JIRA] (ASTERISK-28079) [patch]core: New variables CONNECTED_LINE_ORIGINAL_* for interception routine CONNECTED_LINE_SEND_SUB

[Richard Mudgett (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=245010#comment-245010 ] 

Richard Mudgett commented on ASTERISK-28079:
--------------------------------------------

This patch is not necessary.

When you get a connected line update, the connected line information is already set to the new connected party (Bob) because you are no longer connected to the old party (Alice).  There is no relationship between the old and the new information because Bob is not Alice.  Thus in the normal case this patch wastes resources setting up channel variables and allocating memory that is not needed.

The only reason to revert the connected line information is if you wanted it to stay constant.  There are already several ways to get the constant information to reset the connected line information.  These ways do not require any changes to Asterisk and incur the storage overhead only when this behavior is needed.  I already provided example dialplan in this other review https://gerrit.asterisk.org/#/c/asterisk/+/10286/ to do just that.


> [patch]core: New variables CONNECTED_LINE_ORIGINAL_* for interception routine CONNECTED_LINE_SEND_SUB
> -----------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-28079
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28079
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Core/Channels
>    Affects Versions: 13.23.1
>            Reporter: Alexei Gradinari
>            Severity: Minor
>
> Added new variables
> CONNECTED_LINE_ORIGINAL_ID_NUM
> CONNECTED_LINE_ORIGINAL_ID_NAME
> CONNECTED_LINE_ORIGINAL_ANI_NUM
> CONNECTED_LINE_ORIGINAL_ANI_NAME
> to get the original values inside the interception routine CONNECTED_LINE_SEND_SUB.
> It can help to prevent Connected Line update by reverting to original values
> or alter Connected Line information based on original values.



--
This message was sent by Atlassian JIRA
(v6.2#6252)