[asterisk-bugs] [JIRA] (ASTERISK-28049) res_pjproject build failure

[Friendly Automation (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=244791#comment-244791 ] 

Friendly Automation commented on ASTERISK-28049:
------------------------------------------------

Change 10100 merged by Joshua Colp:
res_pjproject: Fix sockaddr conversion routines for non-bundled PJSIP

[https://gerrit.asterisk.org/10100|https://gerrit.asterisk.org/10100]

> res_pjproject build failure
> ---------------------------
>
>                 Key: ASTERISK-28049
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28049
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: pjproject/pjsip
>    Affects Versions: 13.24.0
>         Environment: Linux
>            Reporter: Jaco Kroon
>            Assignee: Sean Bright
>              Labels: pjsip
>
> {noformat}
>    [CC] res_pjproject.c -> res_pjproject.o
> res_pjproject.c: In function 'ast_sockaddr_to_pj_sockaddr':
> res_pjproject.c:493:27: error: incompatible types when assigning to type 'pj_in_addr {aka struct pj_in_addr}' from type 'struct in_addr'
>    pjaddr->ipv4.sin_addr   = sin->sin_addr;
>                            ^
> res_pjproject.c: In function 'ast_sockaddr_from_pj_sockaddr':
> res_pjproject.c:514:19: error: incompatible types when assigning to type 'struct in_addr' from type 'pj_in_addr {aka const struct pj_in_addr}'
>    sin->sin_addr   = pjaddr->ipv4.sin_addr;
>                    ^
> {noformat}
> Introduced by:
> {noformat}
> commit b0ef54af717147dc369728a88bf6d4994abb4d12
> Author: Sean Bright <sean.bright at gmail.com>
> Date:   Tue Aug 28 09:42:13 2018 -0400
>     res_pjproject: Add utility functions to convert between socket structures
>     
>     Currently, to convert from a pj_sockaddr to an ast_sockaddr, the address
>     needs to be rendered to a string and then parsed into the correct
>     structure. This also involves a call to getaddrinfo(3). The same is true
>     for the inverse operation.
>     
>     Instead, because we know the internal structure of both ast_sockaddr and
>     pj_sockaddr, we can translate directly between the two without the
>     need for an intermediate string.
>     
>     Change-Id: If0fc4bba9643f755604c6ffbb0d7cc46020bc761
> {noformat}
> According to Joshua due to unbundled PJSIP, but still needs to work with unbundled.  Thus setting to MAJOR even though for me this is CRITICAL (distro prohibits bundled packages as far as possible).



--
This message was sent by Atlassian JIRA
(v6.2#6252)