[asterisk-bugs] [JIRA] (ASTERISK-27945) TCP-Peer with insecure=port not found on incoming call

[Olaf Holthausen (JIRA)]

Olaf Holthausen created ASTERISK-27945:
------------------------------------------

             Summary: TCP-Peer with insecure=port not found on incoming call
                 Key: ASTERISK-27945
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27945
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Channels/chan_sip/General, Channels/chan_sip/TCP-TLS
    Affects Versions: 15.4.1, 13.21.1
         Environment: Unbuntu 14.04
            Reporter: Olaf Holthausen


A TCP peer with insecure=port is not found on incoming call if the port is not the same as defined in port=XXX.
in chan_sip.c, function peer_ipcmp_cb_full, the TCP and TLS transports needs to be added in the if statement. Then it works.
Before:
        if (((peer->transports & peer2->transports) &
                (AST_TRANSPORT_UDP | AST_TRANSPORT_WS | AST_TRANSPORT_WSS)) &&
                ast_test_flag(&peer2->flags[0], SIP_INSECURE_PORT)) {
                /* We are allowing match without port for peers configured that
                 * way in this pass through the peers. */
                return ast_test_flag(&peer->flags[0], SIP_INSECURE_PORT) ?
                                (CMP_MATCH | CMP_STOP) : 0;
        }

After:
        if (((peer->transports & peer2->transports) &
                (AST_TRANSPORT_UDP | AST_TRANSPORT_TCP | AST_TRANSPORT_TLS | AST_TRANSPORT_WS | AST_TRANSPORT_WSS)) &&
                ast_test_flag(&peer2->flags[0], SIP_INSECURE_PORT)) {
                /* We are allowing match without port for peers configured that
                 * way in this pass through the peers. */
                return ast_test_flag(&peer->flags[0], SIP_INSECURE_PORT) ?
                                (CMP_MATCH | CMP_STOP) : 0;
        }




--
This message was sent by Atlassian JIRA
(v6.2#6252)