[asterisk-bugs] [JIRA] (ASTERISK-26094) stasis: Playing MOH to bridge with ARI does not work

[Moritz Fain (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-26094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=243931#comment-243931 ] 

Moritz Fain commented on ASTERISK-26094:
----------------------------------------

The problem is that the critical section in {{stasis_app_bridge_moh_channel}} is too short; the lock should only be released *after* {{ast_channel_get_by_name}} logic, right before the return.
Further, there was no cleaning up of the {{moh_wrapper}} in {{moh_channel_thread}} which resulted in cached {{moh_wrapper}} structures being returned from {{ao2_find}} but the channel was already gone.

I made a patch here:
https://github.com/asterisk/asterisk/compare/15.3.0...maurice2k:bugfix-26094

I signed the license agreement, but not sure how to proceed from here with code commits.


> stasis: Playing MOH to bridge with ARI does not work
> ----------------------------------------------------
>
>                 Key: ASTERISK-26094
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26094
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_stasis
>    Affects Versions: 13.9.1, 13.10.0
>         Environment: Ubuntu 14.04.4 LTS
>            Reporter: Cameron
>         Attachments: debug_log_26094, mohbug.js
>
>
> I do the following on an incoming call:
> 1 - Create/Update a bridge using ARI (POST to /bridges/{bridgeid} with custom bridgeid and type=mixing
> 2 - Add current channel to bridge (POST /bridges/{bridgeId}/addChannel). Nothing for role. There is now 1 channel in bridge.
>     -- Channel PJSIP/abc-00000000 joined 'simple_bridge' stasis-bridge <1111a>
> 3 - Play moh (POST to /bridges/{bridgeid}/moh).
> Expected to hear something on channel, but nothing. Console debug says moh started and then immediately says it stopped with no reason why.
>     -- Channel Announcer/ARI_MOH-00000000;2 joined 'simple_bridge' stasis-bridge <1111a>
>     -- Started music on hold, class 'en', on channel 'Announcer/ARI_MOH-00000000;1'
>     -- Stopped music on hold on Announcer/ARI_MOH-00000000;1
> 4 - Play moh again. Same parameters.
> Now moh file plays just fine. The single short wav file plays over and over as expected.
> 5 - Hangup channel, and repeat.
> After the steps above, every time I POST to /bridges/{bridgeid}/moh I get an error back "Allocation failed". Nothing is heard. Nothing is logged on asterisk console for this POST. (Debug 9, verbose 9)



--
This message was sent by Atlassian JIRA
(v6.2#6252)