[asterisk-bugs] [JIRA] (ASTERISK-27961) res_pjsip: Spurious ERROR logging when printing headers in sip_msg

[Nick French (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-27961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick French updated ASTERISK-27961:
-----------------------------------

    Description: 
Asterisk patches the pjproject source to avoid crashing when pjproject sip_msg headers are encountered with NULL vptr's. This logic is correct.

However, in the same patch, error logging was added to announce when these NULL-vtpr headers were seen, but the logic of the logging is to mark an error for every printed header that results in no header text being added to the sip msg, not just when an actual NULL vptr is encountered.

There exists types of headers that are perfectly valid yet result in no header text being added to the sip msg, such as a 'hidden' Route header.
These types should not be treated as an error.

  was:
Asterisk patches the pjproject source to avoid crashing when pjproject sip_msg headers are encountered with NULL vptr's. This logic is correct.

However, in the same patch, error logging was added to announce when these NULL-vtpr headers were seen, but the logic of the logging is to mark an error for every printed header the results in no header text being added to the sip msg, not just when an actual NULL vptr is encountered.

There exists types of headers that are perfectly valid yet result in no header text being added to the sip msg, such as a 'hidden' Route header.
These types should not be treated as an error.


> res_pjsip: Spurious ERROR logging when printing headers in sip_msg
> ------------------------------------------------------------------
>
>                 Key: ASTERISK-27961
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27961
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: pjproject/pjsip
>    Affects Versions: 13.22.0, 15.5.0
>            Reporter: Nick French
>            Severity: Trivial
>              Labels: pjsip
>
> Asterisk patches the pjproject source to avoid crashing when pjproject sip_msg headers are encountered with NULL vptr's. This logic is correct.
> However, in the same patch, error logging was added to announce when these NULL-vtpr headers were seen, but the logic of the logging is to mark an error for every printed header that results in no header text being added to the sip msg, not just when an actual NULL vptr is encountered.
> There exists types of headers that are perfectly valid yet result in no header text being added to the sip msg, such as a 'hidden' Route header.
> These types should not be treated as an error.



--
This message was sent by Atlassian JIRA
(v6.2#6252)