[asterisk-bugs] [JIRA] (ASTERISK-27635) [patch] app_voicemail: Avoid always true warnings with clang.

[Friendly Automation (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=241936#comment-241936 ] 

Friendly Automation commented on ASTERISK-27635:
------------------------------------------------

Change 8086 merged by Jenkins2:
app_voicemail: Avoid always true when using pointer address.

[https://gerrit.asterisk.org/8086|https://gerrit.asterisk.org/8086]

> [patch] app_voicemail: Avoid always true warnings with clang.
> -------------------------------------------------------------
>
>                 Key: ASTERISK-27635
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27635
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_voicemail/IMAP
>    Affects Versions: 13.19.0, 15.2.0
>         Environment: clang 4.0
> FreeBSD 11.1
>            Reporter: Alexander Traud
>            Assignee: Alexander Traud
>            Severity: Trivial
>              Labels: patch
>         Attachments: clang_app_voicemail_with_imap.patch
>
>
> 34 months ago, [review 4541|https://reviewboard.asterisk.org/r/4541/] (ASTERISK-24917) resolved warnings raised by the compiler clang. However, because alternative/conflicting code paths exist, some warnings got missed. Here in this case, the storage for the app _voicemail_ was changed from file to IMAP via {{make menuselect}}.
> Then on FreeBSD 11.1, its default compiler _clang_ (4.0) reports:{code}warning: address of array 'vms->imapuser' will always evaluate to 'true' [-Wpointer-bool-conversion]
> warning: address of array 'vms->username' will always evaluate to 'true' [-Wpointer-bool-conversion]
> warning: address of array 'vms->context' will always evaluate to 'true' [-Wpointer-bool-conversion]{code}two times each, resulting in six warnings.



--
This message was sent by Atlassian JIRA
(v6.2#6252)