[asterisk-bugs] [JIRA] (ASTERISK-27635) [patch] app_voicemail: Avoid always true warnings with clang.

[Alexander Traud (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-27635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Traud updated ASTERISK-27635:
---------------------------------------

    Comment: was deleted

(was: Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].)

> [patch] app_voicemail: Avoid always true warnings with clang.
> -------------------------------------------------------------
>
>                 Key: ASTERISK-27635
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27635
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_voicemail/IMAP
>    Affects Versions: 13.19.0, 15.2.0
>         Environment: clang 4.0
> FreeBSD 11.1
>            Reporter: Alexander Traud
>            Severity: Trivial
>              Labels: patch
>         Attachments: clang_app_voicemail_with_imap.patch
>
>
> 34 months ago, [review 4541|https://reviewboard.asterisk.org/r/4541/] (ASTERISK-24917) resolved warnings raised by the compiler clang. However, because alternative/conflicting code paths exist, some warnings got missed. Here in this case, the storage for the app _voicemail_ was changed from file to IMAP via {{make menuselect}}.
> Then on FreeBSD 11.1, its default compiler _clang_ (4.0) reports:{code}warning: address of array 'vms->imapuser' will always evaluate to 'true' [-Wpointer-bool-conversion]
> warning: address of array 'vms->username' will always evaluate to 'true' [-Wpointer-bool-conversion]
> warning: address of array 'vms->context' will always evaluate to 'true' [-Wpointer-bool-conversion]{code}two times each, resulting in six warnings.



--
This message was sent by Atlassian JIRA
(v6.2#6252)