[asterisk-bugs] [JIRA] (ASTERISK-27631) [patch] BuildSystem: Do not warn when bash is not installed.

[Alexander Traud (JIRA)]

Alexander Traud created ASTERISK-27631:
------------------------------------------

             Summary: [patch] BuildSystem: Do not warn when bash is not installed.
                 Key: ASTERISK-27631
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27631
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Core/BuildSystem
    Affects Versions: 15.2.0, 13.19.0
         Environment: FreeBSD 11.1
            Reporter: Alexander Traud
            Severity: Minor
         Attachments: ignore_list_external_result.patch

The build system includes the script {{build_tools/list_valid_installed_externals}}, which collects all modules installed from Digium, like various audio-codecs and the Digium Phone Module for Asterisk (DPMA; res_digium_phone). Then, the Makefile double-checks the installed modules, whether an old module is still installed. If such an old module is found, {{make install}} prints a big warning.

To be downloaded, those external modules required the shell _bash_. Therefore, it is okay that this script requires the shell _bash_ as well. However, when that shell is not installed, {{make install}} prints the following twice: {{env: bash: No such file or directory}}. This is because the script does not set the shell directly but finds _bash_ via the tool _env_. When the header of the script is changed to {{#!/bin/bash}}, the following is printed twice: {{gmake\[1\]: ./build_tools/list_valid_installed_externals: Command not found}}.

To solve this, one approach is to avoid calling this script when the variable $\{BASH\} is not set. Another approach is to ignore any error of that script.



--
This message was sent by Atlassian JIRA
(v6.2#6252)