[asterisk-bugs] [JIRA] (ASTERISK-27577) [patch] chan_ooh323: Avoid typecasting an int to unsigned short.

[Alexander Traud (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-27577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Traud updated ASTERISK-27577:
---------------------------------------

    Comment: was deleted

(was: Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].)

> [patch] chan_ooh323: Avoid typecasting an int to unsigned short.
> ----------------------------------------------------------------
>
>                 Key: ASTERISK-27577
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27577
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Addons/chan_ooh323
>    Affects Versions: 13.19.0, 15.2.0
>            Reporter: Alexander Traud
>            Severity: Trivial
>              Labels: patch
>         Attachments: truncation_clang_ooh323.patch
>
>
> The compiler _clang_ (5.0.1) reports:{code}chan_ooh323.c:3215:40: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
>                 sprintf(ip_port, "%s:%hu", peer->ip, peer->port);
>                                      ~~~             ^~~~~~~~~~
>                                      %d
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:39:7: note: expanded from macro 'sprintf'
>                            __VA_ARGS__)
>                            ^~~~~~~~~~~
> chan_ooh323.c:3306:58: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
>                 snprintf(ip_port, sizeof(ip_port), "%s:%hu", peer->ip, peer->port);
>                                                        ~~~             ^~~~~~~~~~
>                                                        %d
> {code}This issue is caused by the fix for ASTERISK-27156. Because the array _ip_port_ was already increased enough, this change was not needed actually. Therefore, it is simply a partly revert. In other words: The compiler _gcc_ does warn even after reverting this.



--
This message was sent by Atlassian JIRA
(v6.2#6252)