[asterisk-bugs] [JIRA] (ASTERISK-27569) Not answering call on Polarity reversal Event

[Kevin Harwell (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=241463#comment-241463 ] 

Kevin Harwell commented on ASTERISK-27569:
------------------------------------------

[~pushkar.singh], Sounds like you have a pretty good idea as to a fix. That being the case, I'd highly recommend submitting a patch for code review by the Asterisk Developer Community. 

To do so, please follow the Code Review [1] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines [2]
* Review the Code Review Checklist [3] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4]

When ready, submit your patch and any tests to Gerrit [5] for code review.

Thanks!

[1] https://wiki.asterisk.org/wiki/display/AST/Code+Review
[2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
[3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
[4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
[5] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage

> Not answering call on Polarity reversal Event
> ---------------------------------------------
>
>                 Key: ASTERISK-27569
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27569
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_dahdi
>    Affects Versions: 15.1.5
>         Environment: Linux
>            Reporter: Pushkar Singh
>
> It seems that even though after detecting polarity reversal on asterisk, Asterisk does not answer the call.
> On further debugging on the issue it seems that, if "answeronpolarityswitch" is set to "yes" and "callprogress" is set to "no" as soon as call is answered and polarity reversal is detected by asterisk, Asterisk change the call state to UP but actually doesnot sending CONTORL_ANSWER frame to core.
> Below is the code snippet in order to support the above statement:
>  8122                         if (p->answeronpolarityswitch &&
>  8123                                 ((ast_channel_state(ast) == AST_STATE_DIALING) ||
>  8124                                 (ast_channel_state(ast) == AST_STATE_RINGING))) {
>  8125                                 ast_debug(1, "Answering on polarity switch!\n");
>  8126                                 ast_setstate(p->owner, AST_STATE_UP);
>  8127                                 if (p->hanguponpolarityswitch) {



--
This message was sent by Atlassian JIRA
(v6.2#6252)