[asterisk-bugs] [JIRA] (ASTERISK-27689) [patch] rtp_engine: Load format name / mime type in uppercase again.

[Alexander Traud (JIRA)]

Alexander Traud created ASTERISK-27689:
------------------------------------------

             Summary: [patch] rtp_engine: Load format name / mime type in uppercase again.
                 Key: ASTERISK-27689
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27689
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Core/RTP
    Affects Versions: 15.0.0, 13.12.0
         Environment: 3GPP EVS with Samsung GALAXY S7
            Reporter: Alexander Traud
         Attachments: upper_case_payload_format_name.patch

Change [3360|http://gerrit.asterisk.org/3360] (commit [852e76|http://github.com/asterisk/asterisk/commit/852e7635719e4b217094786819df996816d82ab5]) made the symbol {{ast_rtp_engine_load_format(.)}} usable. That symbol allows the easy integration of new format modules, like the one for Codec 2 and other external ones like [mine|http://github.com/traud?tab=repositories&q=asterisk]. Instead of patching the file {{main/rtp_engine.c}} one can use {{ast_rtp_engine_load_format(.)}} directly within a transcoding module.

However, that change overdid it a bit by removing the upper-case of the payload format (encoding) name. Yes, [RFC 4855|http://tools.ietf.org/html/rfc4855#section-3] section 3 last paragraph states that this name shall be case-insensitive. Therefore, that change should not have any effect. However, in IETF RFCs and 3GPP TSs, that name is always shown in upper-case format. Therefore, some implementations are expecting the payload format name in upper-case. One such example is [documented for 3GPP EVS...|http://github.com/traud/asterisk-evs/issues/2]

Currently, in SIP SDP the name is printed in lower case. With a broken remote party, the format is not chosen which leads to reduced functionality, might lead to reduced quality and end even in no call establishment at all. Therefore, the attached patch reverses that part of the change and re-introduces upper-case again.

Within Asterisk, this affects only the audio codec Codec 2. All known Codec 2 implementations accept both lower- and upper-case.



--
This message was sent by Atlassian JIRA
(v6.2#6252)