[asterisk-bugs] [JIRA] (ASTERISK-26108) parking: Cannot create parking lots with extension over 2147483647

khb (JIRA) noreply at issues.asterisk.org
Thu Aug 16 11:14:54 CDT 2018


    [ https://issues.asterisk.org/jira/browse/ASTERISK-26108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=244525#comment-244525 ] 

khb edited comment on ASTERISK-26108 at 8/16/18 11:13 AM:
----------------------------------------------------------

Here are patches for Asterisk 13.22.0 and for Asterisk 16.0.0-rc1. The 16-patch also cleanly applies and compiles with this week's clone from Gerrit.

The 13-patch was tested on a source-compiled 32-bit system, and by patching, rebuilding, and installing RPM distro files for a FreePBX distribution upgraded to Asterisk 13.22.0 on a x86_64 VM system.

The two patches are different, accounting for later additions to the parking code.

The strategy of the patches is to extend all integers (int and unsigned int) that represent parking extensions to use long long integers by using a typedef ast_parkingspace_int to visibly identify those variables that need the extension, which is not in all places obvious without understanding of the details of the code.



was (Author: khb):
Here are patches for Asterisk 13.22.0 and for Asterisk 16.0.0-rc1. The 16-patch also cleanly applies and compiles with this week's clone from Gerrit.

The 13-patch was tested on a source-compiled 32-bit system, and by patching, rebuilding, and installing RPM distro files for a FreePBX distribution upgraded to Asterisk 13.22.0 on a x86_64 VM system.

The two patches are different, accounting for later additions to the parking code.

The strategy of the patches is to extend all integers (int and unsigned int) that represent parking extensions to use long long integers by using a typedef ast_parkingspace_int to visibly identify those variable that need the extension, which is not in all places obvious without understanding of the details of the code.


> parking: Cannot create parking lots with extension over 2147483647
> ------------------------------------------------------------------
>
>                 Key: ASTERISK-26108
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26108
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Features/Parking
>    Affects Versions: 11.20.0
>         Environment: FreePBX Distro 6.12.65-31
>            Reporter: David Sovereen
>            Severity: Minor
>              Labels: patch
>         Attachments: ASTERISK-26108_parking-ast13.22.patch, ASTERISK-26108_parking-ast16.0.0.patch
>
>
> Cannot make parking lots with an extension that exceeds 2147483647.  "features reload" succeeds, but "features show" shows extensions counting back as you go over 2147483627 and extensions more than double 2147483627 don't show up at all.
> In my features.conf, I have (among other things):
> [parkinglot_44]
> parkext=2147483649
> parkpos=2147483650-2147483650
> context=parkinglot_44
> parkext_exclusive=yes
> parkingtime=45
> comebacktoorigin=no
> parkedplay=both
> parkedcalltransfers=caller
> parkedcallreparking=caller
> parkedmusicclass=default
> findslot=first
> [parkinglot_45]
> parkext=9898373790700
> parkpos=9898373790701-9898373790702
> context=parkinglot_45
> parkext_exclusive=yes
> parkingtime=45
> comebacktoorigin=no
> parkedplay=both
> parkedcalltransfers=caller
> parkedcallreparking=caller
> parkedmusicclass=default
> findslot=first
> Note that the first one, parkinglot_44, is just over the magic 2147483647 number.  After a "features reload", the parking lot shows as a different extension, 2147483640:
> Call parking (Parking lot: parkinglot_44)
> ------------
> Parking extension     :      2147483640
> Parking context       :      parkinglot_44
> Parked call extensions:      2147483641-2147483641
> Parkingtime           :      45000 ms
> Comeback to origin    :      no
> Comeback context      :      parkedcallstimeout
> Comeback dial time    :      30
> MusicOnHold class     :      default
> Enabled               :      Yes
> The second parking lot configured at extension 9898373790700 does not appear in "features show" at all.
> We have telephone extensions and other things on our Asterisk systems using numbers larger than 2147483647, but Parking Lots seem to have this limitation.  It would seem that they are stored in the database or in memory as an integer instead of a large integer or string.  I'm hoping this can be fixed, as our internal, normalized naming convention creates parking lots with extension numbers larger than 2147483647.
> Thanks,
> Dave 



--
This message was sent by Atlassian JIRA
(v6.2#6252)



More information about the asterisk-bugs mailing list