[asterisk-bugs] [JIRA] (ASTERISK-28005) channel.c: ARI ring only once

[Benjamin Keith Ford (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=244487#comment-244487 ] 

Benjamin Keith Ford edited comment on ASTERISK-28005 at 8/14/18 9:51 AM:
-------------------------------------------------------------------------

[~hajekmi], would you like to submit your patch to Gerrit [1]? Many developers will be able to look at your patch and review it here, helping to get it merged into the code base. A full guide on how to get started with Gerrit can be found here [2].

As Richard said, the patch in its current state won't be acceptable as a solution, but if you would like to work on another solution, this would be the process to follow to get feedback and any help you may need to resolve the issue.

[1] https://gerrit.asterisk.org/#/q/status:open
[2] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage


was (Author: bford):
[~hajekmi], would you like to submit your patch to Gerrit [1]? Many developers will be able to look at your patch and review it here, helping to get it merged into the code base. A full guide on how to get started with Gerrit can be found here [2].

[1] https://gerrit.asterisk.org/#/q/status:open
[2] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage

> channel.c: ARI ring only once
> -----------------------------
>
>                 Key: ASTERISK-28005
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28005
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/General
>    Affects Versions: 15.4.0, 15.5.0
>         Environment: CentOS release 6.9
>            Reporter: Hajek Michal
>            Assignee: Hajek Michal
>              Labels: patch
>         Attachments: ari_ringing_fix.patch, full_ringingfixed.txt, full_ringingissue.txt
>
>
> There is some issue when making request ari/ring on answered channel.
> Steps I use to reproduce:
> 1. call from SIP/322 to Stasis app
> 2. in Stasis app making requests: answer, create bridge, add channel to bridge and originate channel SIP/611 (after dial goto Stasis app).
> 3. second channel SIP/611 arrive to same Stasis app and add channel to bridge
> 4. situation: SIP/322 -->bridge<-- SIP/611
> 5. on first channel SIP/322 making requests hold and mute (ari)
> 6. *bug* on second channel SIP/611 making request ring - a hear only once ringing tone. There is no ringing tone repeatedly.
> On asterisk 15.3.0 this bug not reflected.
> I found a commit who broke it https://github.com/asterisk/asterisk/commit/ad3a8dc49710b6ac9b6ece2953fa8b39dccfeb0d#diff-43bfdcf1afb13c834cbfa2aff372eabe
> I tried writing patch for asterisk 15.4.0 and 15.5.0, can you verify?



--
This message was sent by Atlassian JIRA
(v6.2#6252)