[asterisk-bugs] [JIRA] (ASTERISK-28002) When T.140 realtime text is negociated, a lot of debug traces are generated

[Emmanuel BUU (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-28002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel BUU updated ASTERISK-28002:
------------------------------------

    Description: 
If we process a call with T.140/RED and activate debug traces

core set debug 1

We get a constant flow of traces:

Received frame with no data for RTP instance 'xxxx' so dropping frame

We propose the follwing simple fix in res_rtp_asterisk.c

In :

{code:title=res_rtp_asterisk.c}
static int red_write(const void *data)
{
        struct ast_rtp_instance *instance = (struct ast_rtp_instance*) data;
        struct ast_rtp *rtp = ast_rtp_instance_get_data(instance);

        ao2_lock(instance);
        ast_rtp_write(instance, &rtp->red->t140);
        ao2_unlock(instance);

        return 1;
}
{code}

Correct the line

{code:title=res_rtp_asterisk.c}
if (rtp->red->t140.datalen > 0) {
     ast_rtp_write(instance, &rtp->red->t140);
}
{code}


  was:
If we process a call with T.140/RED and activate debug traces

core set debug 1

We get a constant flow of traces:

Received frame with no data for RTP instance 'xxxx' so dropping frame

We propose the follwing simple fix in res_rtp_asterisk.c

In :

static int red_write(const void *data)
{
        struct ast_rtp_instance *instance = (struct ast_rtp_instance*) data;
        struct ast_rtp *rtp = ast_rtp_instance_get_data(instance);

        ao2_lock(instance);
        ast_rtp_write(instance, &rtp->red->t140);
        ao2_unlock(instance);

        return 1;
}

Correct the line

if (rtp->red->t140.datalen > 0) {
     ast_rtp_write(instance, &rtp->red->t140);
}




> When T.140 realtime text is negociated, a lot of debug traces are generated
> ---------------------------------------------------------------------------
>
>                 Key: ASTERISK-28002
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28002
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_rtp_asterisk
>    Affects Versions: 13.22.0
>         Environment: Cent OS 7 - 
>            Reporter: Emmanuel BUU
>            Severity: Minor
>
> If we process a call with T.140/RED and activate debug traces
> core set debug 1
> We get a constant flow of traces:
> Received frame with no data for RTP instance 'xxxx' so dropping frame
> We propose the follwing simple fix in res_rtp_asterisk.c
> In :
> {code:title=res_rtp_asterisk.c}
> static int red_write(const void *data)
> {
>         struct ast_rtp_instance *instance = (struct ast_rtp_instance*) data;
>         struct ast_rtp *rtp = ast_rtp_instance_get_data(instance);
>         ao2_lock(instance);
>         ast_rtp_write(instance, &rtp->red->t140);
>         ao2_unlock(instance);
>         return 1;
> }
> {code}
> Correct the line
> {code:title=res_rtp_asterisk.c}
> if (rtp->red->t140.datalen > 0) {
>      ast_rtp_write(instance, &rtp->red->t140);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)