[asterisk-bugs] [JIRA] (ASTERISK-27816) func_talkdetect's logic is completely broken

[Moritz Fain (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=243144#comment-243144 ] 

Moritz Fain commented on ASTERISK-27816:
----------------------------------------

Thanks [~rmudgett] for the explanation!

I just found another solution using the {{duration}} field in the talking finished event.
That way I could implement the talking threshold client side, which would reduce the patch and keep it 100% compatible.

The patch now fixes two things:
- only emit a talking started event if there was talking/noise (currently *always* emits an event right after the channel is being answered)
- fixes negative durations for very small durations caused by timing issues by setting everything <0 to zero.

> func_talkdetect's logic is completely broken
> --------------------------------------------
>
>                 Key: ASTERISK-27816
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27816
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Functions/func_talkdetect
>    Affects Versions: 15.3.0
>            Reporter: Moritz Fain
>
> Logic in func_talkdetect.c is completely wrong regarding the thresholds. It is mixing millisecond thresholds (the one's that are passed to TALK_DETECT via set) with the DSP's avg. amplitude thresholds.



--
This message was sent by Atlassian JIRA
(v6.2#6252)