[asterisk-bugs] [JIRA] (ASTERISK-27816) func_talkdetect's logic is completely broken

[Richard Mudgett (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=243093#comment-243093 ] 

Richard Mudgett commented on ASTERISK-27816:
--------------------------------------------

This looks like another place where the threshold *documentation* needs fixing.  I updated the documentation for app_confbridge for the same thing in this review (changes were first released in 13.20.0 and 15.3.0):
https://gerrit.asterisk.org/#/c/8115/

> func_talkdetect's logic is completely broken
> --------------------------------------------
>
>                 Key: ASTERISK-27816
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27816
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Functions/func_talkdetect
>    Affects Versions: 15.3.0
>            Reporter: Moritz Fain
>
> Logic in func_talkdetect.c is completely wrong regarding the thresholds. It is mixing millisecond thresholds (the one's that are passed to TALK_DETECT via set) with the DSP's avg. amplitude thresholds.



--
This message was sent by Atlassian JIRA
(v6.2#6252)