[asterisk-bugs] [JIRA] (ASTERISK-27253) [patch] libsrtp-2.1.x support

[Asterisk Team (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=238493#comment-238493 ] 

Asterisk Team commented on ASTERISK-27253:
------------------------------------------

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

> [patch] libsrtp-2.1.x support
> -----------------------------
>
>                 Key: ASTERISK-27253
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27253
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Resources/res_srtp
>    Affects Versions: 13.15.1
>            Reporter: Alexander Traud
>            Severity: Minor
>
> Since ASTERISK-26976, libSRTP 2.0.x can be linked. However since libSRTP 2.1.x, the macro {{SRTP_AES_ICM}} got renamed to {{SRTP_AES_ICM_128}} (see commit [2a481bb|http://github.com/cisco/libsrtp/commit/2a481bb1434e4bbb2ce6c95ce1ec227e6e344259] and [d335bd8|http://github.com/cisco/libsrtp/commit/d335bd88b147cf0fdf956bd21a55d3c7c9d974d7]). Because of that, Asterisk 13 does not compile when libSRTP 2.1.x is present:
> {code}
>    [CC] res_srtp.c -> res_srtp.o
> In file included from res_srtp.c:45:0:
> res_srtp.c: In function ‘policy_set_suite’:
> srtp/srtp_compat.h:8:21: error: ‘SRTP_AES_ICM’ undeclared (first use in this function)
>  #define AES_128_ICM SRTP_AES_ICM
>                      ^
> res_srtp.c:267:20: note: in expansion of macro ‘AES_128_ICM’
>    p->cipher_type = AES_128_ICM;
>                     ^~~~~~~~~~~
> srtp/srtp_compat.h:8:21: note: each undeclared identifier is reported only once for each function it appears in
>  #define AES_128_ICM SRTP_AES_ICM
>                      ^
> res_srtp.c:267:20: note: in expansion of macro ‘AES_128_ICM’
>    p->cipher_type = AES_128_ICM;
>                     ^~~~~~~~~~~
> Makefile.rules:149: recipe for target 'res_srtp.o' failed
> make[1]: *** [res_srtp.o] Error 1
> Makefile:368: recipe for target 'res' failed
> make: *** [res] Error 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)