[asterisk-bugs] [JIRA] (DAHLIN-356) Compilation fails on 4.13

[Sean Darcy (JIRA)]

    [ https://issues.asterisk.org/jira/browse/DAHLIN-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=239586#comment-239586 ] 

Sean Darcy commented on DAHLIN-356:
-----------------------------------

As long as there's going to be a dahdi release, maybe clean up some warnings ? gcc 7.2.1 on fedora.

make[1]: Entering directory '/usr/src/kernels/4.13.5-200.fc26.x86_64'
  CC [M]  /home/asterisk/rpmbuild/BUILD/dahdi-linux-next/drivers/dahdi/dahdi-base.o
/home/asterisk/rpmbuild/BUILD/dahdi-linux-next/drivers/dahdi/dahdi-base.c: In function 'dahdi_ioctl_setconf':
/home/asterisk/rpmbuild/BUILD/dahdi-linux-next/drivers/dahdi/dahdi-base.c:5712:3: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
   memset(chan->conflast, 0, DAHDI_MAX_CHUNKSIZE);
   ^~~~~~
/home/asterisk/rpmbuild/BUILD/dahdi-linux-next/drivers/dahdi/dahdi-base.c:5713:3: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
   memset(chan->conflast1, 0, DAHDI_MAX_CHUNKSIZE);
   ^~~~~~
/home/asterisk/rpmbuild/BUILD/dahdi-linux-next/drivers/dahdi/dahdi-base.c:5714:3: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
   memset(chan->conflast2, 0, DAHDI_MAX_CHUNKSIZE);
   ^~~~~~
  CC [M]  /home/asterisk/rpmbuild/BUILD/dahdi-linux-next/drivers/dahdi/dahdi-sysfs.o
In file included from /home/asterisk/rpmbuild/BUILD/dahdi-linux-next/include/dahdi/kernel.h:42:0,
                 from /home/asterisk/rpmbuild/BUILD/dahdi-linux-next/drivers/dahdi/dahdi-sysfs.c:26:
./include/linux/device.h:584:26: warning: 'dev_attr_is_sync_master' defined but not used [-Wunused-variable]
  struct device_attribute dev_attr_##_name = __ATTR_RO(_name)
                          ^
/home/asterisk/rpmbuild/BUILD/dahdi-linux-next/drivers/dahdi/dahdi-sysfs.c:225:8: note: in expansion of macro 'DEVICE_ATTR_RO'
 static DEVICE_ATTR_RO(is_sync_master);
        ^~~~~~~~~~~~~~
./include/linux/device.h:584:26: warning: 'dev_attr_lbo' defined but not used [-Wunused-variable]
  struct device_attribute dev_attr_##_name = __ATTR_RO(_name)
                          ^
/home/asterisk/rpmbuild/BUILD/dahdi-linux-next/drivers/dahdi/dahdi-sysfs.c:222:8: note: in expansion of macro 'DEVICE_ATTR_RO'
 static DEVICE_ATTR_RO(lbo);
        ^~~~~~~~~~~~~~


> Compilation fails on 4.13
> -------------------------
>
>                 Key: DAHLIN-356
>                 URL: https://issues.asterisk.org/jira/browse/DAHLIN-356
>             Project: DAHDI-Linux
>          Issue Type: Bug
>      Security Level: None
>         Environment: Kernel >= 4.13
>            Reporter: Jean-Denis Girard
>            Assignee: Shaun Ruffell
>            Severity: Blocker
>         Attachments: dev_attrs_groups.patch, dev_attrs_groups-v2.patch, dev_attrs_groups-v3.patch
>
>
> dev_attrs was removed from struct bus_type on kernel 4.13, need to convert to dev_groups, see http://lkml.iu.edu/hypermail/linux/kernel/1706.0/04578.html.
> I made a patch and sent a pull request on github.



--
This message was sent by Atlassian JIRA
(v6.2#6252)