[asterisk-bugs] [JIRA] (ASTERISK-27356) [patch] libsrtp-2.x.x + AES-GCM support

[Asterisk Team (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=239421#comment-239421 ] 

Asterisk Team commented on ASTERISK-27356:
------------------------------------------

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

> [patch] libsrtp-2.x.x + AES-GCM support
> ---------------------------------------
>
>                 Key: ASTERISK-27356
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27356
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Resources/res_srtp
>    Affects Versions: 14.6.0, 15.0.0
>            Reporter: Alexander Traud
>            Severity: Minor
>
> Since ASTERISK-26976, libSRTP 2.x.x can be linked. However, the user might have linked libSRTP to OpenSSL. In that case, libSRTP supports AES-GCM which is auto-detected since ASTERISK-26190. Then, two additional DEFINEs are accessed in libSRTP. However, those were not covered by ASTERISK-26976 and therefore Asterisk does not compile when libSRTP 2.x.x with AES-GCM is present:
> {code}
>    [CC] res_srtp.c -> res_srtp.o
> res_srtp.c: In function ‘res_sdp_crypto_parse_offer’:
> res_srtp.c:901:22: error: ‘AES_128_GCM_KEYSIZE_WSALT’ undeclared (first use in this function)
>    key_len_expected = AES_128_GCM_KEYSIZE_WSALT;
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~
> res_srtp.c:901:22: note: each undeclared identifier is reported only once for each function it appears in
> res_srtp.c:906:22: error: ‘AES_256_GCM_KEYSIZE_WSALT’ undeclared (first use in this function)
>    key_len_expected = AES_256_GCM_KEYSIZE_WSALT;
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~
> Makefile.rules:149: recipe for target 'res_srtp.o' failed
> make[1]: *** [res_srtp.o] Error 1
> Makefile:367: recipe for target 'res' failed
> make: *** [res] Error 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)