[asterisk-bugs] [JIRA] (ASTERISK-27448) Add ability to send progress inband by setting a channel variable instead of fixed config per endpoint

[nappsoft (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=240330#comment-240330 ] 

nappsoft commented on ASTERISK-27448:
-------------------------------------

Hi Benjamin. I know about gerrit, a patch of mine has just been checked into the code a few days ago ;) However in this case here I'm neither sure whether someone will think that this patch might be usefull nor did I do enough research about the locking topology. So I guess that Jira is a better place for "usefull or not" and "what's the clean way to do this" discussions than a code review tool... (Or do you think that gerrit should be polluted with simple suggestions?)

> Add ability to send progress inband by setting a channel variable instead of fixed config per endpoint
> ------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-27448
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27448
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Channels/chan_pjsip
>    Affects Versions: 13.18.2
>            Reporter: nappsoft
>            Severity: Minor
>         Attachments: progressinband.diff
>
>
> I've faced a problem with several voip switches when using 180 Ringing messages after announcements sent over 183 Session Progress with SDP (no audible progress indication after Progress followed by Playback). The solution would be to use inband_progress=yes but this way progress will be sent as rtp for each call, so as well in cases in which it is not necessary.
> So my idea was to set a channel variable PROGRESSINBAND to 1 in situations in which we use Progress() followed by Playback().
> I've added some code to chan_pjsip.c which seems to work. I've opened a ticket here for two reasons: one: the "hack" could be usefull for someone else and second: I wanted to ask whether it is safe to do it the way I solved this or whether I'd need to lock channel->session->channel or something else first?



--
This message was sent by Atlassian JIRA
(v6.2#6252)