[asterisk-bugs] [JIRA] (ASTERISK-27435) [patch] configure: pjsip_evsub_set_uas_timeout not found.

[Friendly Automation (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=240206#comment-240206 ] 

Friendly Automation commented on ASTERISK-27435:
------------------------------------------------

Change 7303 merged by Joshua Colp:
BuildSystem: pjsip_evsub_set_uas_timeout was not used.

[https://gerrit.asterisk.org/7303|https://gerrit.asterisk.org/7303]

> [patch] configure: pjsip_evsub_set_uas_timeout not found.
> ---------------------------------------------------------
>
>                 Key: ASTERISK-27435
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27435
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/BuildSystem
>    Affects Versions: 13.8.2, 15.1.2
>            Reporter: Alexander Traud
>            Severity: Trivial
>         Attachments: build_system.patch
>
>
> {quote}An earlier approach was to add support for setting pjproject's timer (via a pjproject patch) and while that patch is still included here, we don't use that call at the moment.{quote}
> Version controlled source code should not contain dead code, because if the code must be found again, it is still within the versioning system. 
> Furthermore, that code broke, because Teluu, the maintainers of PJSIP, [flipped|http://trac.pjsip.org/repos/changeset/5558] the name of that function from pjsip_evsub_*uas_set*\_timeout to pjsip_evsub_*set_uas*\_timeout, while they included the proposed patch.
> Because of this, _configure_ is not able to find that symbol in PJSIP 2.7. Because of this, the user might get confused what is wrong with his PJSIP, especially if he is using not the bundled but an external one.
> The attached patch avoids to look for that unused symbol.



--
This message was sent by Atlassian JIRA
(v6.2#6252)