[asterisk-bugs] [JIRA] (ASTERISK-26911) chan_sip: Should test case-insensitive for occurence of "RTP/AVP" in SDP RTP profile

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-26911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=236242#comment-236242 ] 

Rusty Newton edited comment on ASTERISK-26911 at 3/31/17 3:38 PM:
------------------------------------------------------------------

Features requests without patches are not accepted through the issue tracker. Features requests are openly discussed on the mailing lists, forums, and IRC [1]. Please see the Asterisk Issue Guidelines [2] for more information on feature request and patch submission.

[1] http://asterisk.org/community/discuss
[2] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines

If a patch is created then we can re-open the issue in the future. This issue is highly unlikely to be tackled if left open, because chan_sip is under extended support for a while now. Very few people are working on new features for the old channel driver. The development focus is now on chan_pjsip/res_pjsip.


was (Author: rnewton):
Features requests without patches are not accepted through the issue tracker. Features requests are openly discussed on the mailing lists, forums, and IRC [1]. Please see the Asterisk Issue Guidelines [2] for more information on feature request and patch submission.

[1] http://asterisk.org/community/discuss
[2] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines

If a patch is created then we can re-open the issue in the future.

> chan_sip: Should test case-insensitive for occurence of "RTP/AVP" in SDP RTP profile
> ------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-26911
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26911
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Channels/chan_sip/CodecHandling
>    Affects Versions: 11.25.1, 12.8.2, 13.11.2, 13.14.0, 14.3.0
>            Reporter: mgrobecker
>            Severity: Minor
>
> There are PBXes outside which are sending SDP offers with lowercase strings in the protocol description.
> Example from Swyx:
> -----------------------
> v=0
> o=- 3699694938 3699694939 IN IP4 192.168.0.10
> s=pjmedia
> c=IN IP4 192.168.0.10
> b=AS:84
> t=0 0
> a=X-nat:0
> m=audio 15028 rtp/avp 8 101
> b=TIAS:64000
> a=rtcp:50013 IN IP4 192.168.0.10
> a=sendrecv
> a=rtpmap:8 PCMA/8000
> a=rtpmap:101 telephone-event/8000
> a=fmtp:101 0-16
> -----------------------
> With "m=audio 15028 rtp/avp 8 101" in lowercase letters, Asterisk is unable to use this offer:
> -----------------------
> chan_sip.c:10353 process_sdp: Unknown RTP profile in audio offer: audio 15028 rtp/avp 8 101
> -----------------------
> This is because Asterisk is using "strcmp" in process_sdp() and is checking against an uppercase "RTP/AVP" only.
> The corresponding RFC 4317 (page 7) states, that the value of an SDP element is considered case-sensitive, so IMHO Asterisk is not behaving wrong at this point.
> But it would be a compatibility improvement at a low cost when searching for "RTP/AVP" case-insensitive with "strcasecmp".



--
This message was sent by Atlassian JIRA
(v6.2#6252)