[asterisk-bugs] [JIRA] (ASTERISK-17067) Long lines in call files cause spurious syntax error

Friendly Automation (JIRA) noreply at issues.asterisk.org
Tue Mar 7 17:24:10 CST 2017


    [ https://issues.asterisk.org/jira/browse/ASTERISK-17067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=235598#comment-235598 ] 

Friendly Automation commented on ASTERISK-17067:
------------------------------------------------

Change 5126 merged by zuul:
pbx_spool: Gracefully handle long lines in call files

[https://gerrit.asterisk.org/5126|https://gerrit.asterisk.org/5126]

> Long lines in call files cause spurious syntax error
> ----------------------------------------------------
>
>                 Key: ASTERISK-17067
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-17067
>             Project: Asterisk
>          Issue Type: Bug
>          Components: PBX/pbx_spool
>            Reporter: Dave Olszewski
>            Assignee: Sean Bright
>            Severity: Minor
>
> The main loop in pbx/pbx_spool.c:apply_outgoing uses fgets() to loop over the lines in the call file, but the buffer size is only 256 and it never checks if the characters read contain a newline.  This means that any line longer than 256 will likely cause a syntax error on the next read, because it picks up where the last read left off, in addition to mishandling the first short read.
> This issue appears to have been around for a long time, and is also reported at http://projectb14ck.org/the-asterisk-spooling-daemon



--
This message was sent by Atlassian JIRA
(v6.2#6252)



More information about the asterisk-bugs mailing list