[asterisk-bugs] [JIRA] (ASTERISK-21809) [patch] sip_pvt members novideo and notext are being reset to TRUE every time SDP is processed

[Rusty Newton (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-21809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rusty Newton closed ASTERISK-21809.
-----------------------------------

    Resolution: Won't Fix

Closing this out since there has been no movement since 2013 and it was filed against a now EOL version of Asterisk. With no core development on chan_sip now, this patch is unlikely to get merged in.

If the patch is compatible with a currently supported version please request to reopen the issue and update it to reflect that information. At that point a community developer is welcome to walk the patch through the review process at any time.

> [patch] sip_pvt members novideo and notext are being reset to TRUE every time SDP is processed
> ----------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-21809
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21809
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/Video
>    Affects Versions: 1.8.22.0
>            Reporter: Roman S.
>            Severity: Minor
>         Attachments: asterisk-1.8.22.0-sip-novideo-fix.diff
>
>
> {{sip_pvt::novideo}} and {{sip_pvt::notext}} is being reset to default value in {{process_sdp()}}:
> {noformat}
>  9265         /* default: novideo and notext set */                                                     
>  9266         p->novideo = TRUE;                                                                        
>  9267         p->notext = TRUE;    
> {noformat}
> But in case of re-INVITE with the same SDP version:
> {noformat}
>  9281                         /* If we end up receiving SDP that doesn't actually modify the session we don't want to treat this as a fatal
>  9282                          * error. We just want to ignore the SDP and let the rest of the packet be handled as normal.
>  9283                          */                                                                       
>  9284                         if (!process_sdp_o(value, p)) {                                           
>  9285                                 return (p->session_modify == FALSE) ? 0 : -1;
> {noformat}
>  values of mentioned variables stay default. This isn't correct in case if video is present (already established). As result Asterisk sends 200 OK answer with audio only media.
> I suppose that it's better to set variables to default values in {{sip_alloc()}}



--
This message was sent by Atlassian JIRA
(v6.2#6252)