[asterisk-bugs] [JIRA] (ASTERISK-26739) voicemail API test: confuses expected and actual values

[Friendly Automation (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-26739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=234901#comment-234901 ] 

Friendly Automation commented on ASTERISK-26739:
------------------------------------------------

Change 4775 merged by George Joseph:
test_voicemail_api: order of params to VERIFY macros

[https://gerrit.asterisk.org/4775|https://gerrit.asterisk.org/4775]

> voicemail API test: confuses expected and actual values
> -------------------------------------------------------
>
>                 Key: ASTERISK-26739
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26739
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Tests/General
>            Reporter: Tzafrir Cohen
>            Assignee: Rusty Newton
>            Severity: Trivial
>
> I had a voicemail test fail for me:
> {code}
> [test_voicemail_api.c:voicemail_api_nominal_msg_playback:1455]: Playing back message from test_vm_api_2345 to callback function with default context
> [test_voicemail_api.c:voicemail_api_nominal_msg_playback:1461]: Test failed for parameter 2: Expected [3], Actual [2]
> END    /main/voicemail_api/ - nominal_msg_playback Time: 96ms Result: FAIL
> {code}
> However, the source of the test shows:
> {code}
> VM_API_INT_VERIFY(test_mbox_snapshot->total_msg_num, 2);
> {code}
> The expected value is 3? Not 2?
> Indeed, the macro up that source file:
> {code}
> #define VM_API_INT_VERIFY(expected, actual)
> {code}
> Thus I believe that most usages of that and similar macros in that file should be reversed (or change the macro. There are some correct usages of the macro).



--
This message was sent by Atlassian JIRA
(v6.2#6252)