[asterisk-bugs] [JIRA] (ASTERISK-15710) [patch] app_queue: Log failed attempts to call members

[Physis Heckman (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-15710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=234624#comment-234624 ] 

Physis Heckman commented on ASTERISK-15710:
-------------------------------------------

I try to use your patch, but some errors occurred to asterisk-11-current (11.25.1) 

/usr/src/asterisk-11.25.1# patch apps/app_queue.c < /usr/src/rev295023-issue0016925-app_queue.c.patch
patching file apps/app_queue.c
Hunk #1 succeeded at 1366 with fuzz 2 (offset 335 lines).
Hunk #2 FAILED at 2884.
Hunk #3 FAILED at 2967.
Hunk #4 FAILED at 3189.
Hunk #5 FAILED at 3209.
Hunk #6 FAILED at 3216.
Hunk #7 FAILED at 3515.
Hunk #8 FAILED at 3533.
Hunk #9 succeeded at 4636 with fuzz 1 (offset 1033 lines).
Hunk #10 FAILED at 3648.
8 out of 10 hunks FAILED -- saving rejects to file apps/app_queue.c.rej
patching file apps/app_queue.c
Hunk #1 FAILED at 30.
1 out of 1 hunk FAILED -- saving rejects to file apps/app_queue.c.rej

link app_queue.c.rej http://pastebin.com/qFVtF7Rr
link app_queue.c asterisk-11.25.1 http://pastebin.com/GJWG5vMT



> [patch] app_queue: Log failed attempts to call members
> ------------------------------------------------------
>
>                 Key: ASTERISK-15710
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-15710
>             Project: Asterisk
>          Issue Type: New Feature
>          Components: Applications/app_queue
>            Reporter: Håkon Nessjøen
>         Attachments: issue0016925-app_queue.c.patch, rev295023-issue0016925-app_queue.c.patch, tringenbach_rna_hangupcause2.diff, tringenbach_rna_hangupcause.diff
>
>
> This patch enables logging of all call attempts from a queue. Not only the ones that do not fail.
> The patch also introduces a new parameter "congestion" to both RINGNOANSWER in queue_log and AgentRingNoAnswer AMI event, which is set to 1 if the call failed to go through because of technical difficulties.
> This makes it easier to make queue_log statistics with information about problems with an agent. For example if an agent has a faulty line, or your telco/dahdi connection is having problems.
> I am however unsure if everyone want this marked as an congestion from the "AST_CONTROL_CONGESTION" frame. Since in my experience, this can come if a SIP UA doesn't want to let you ring more than x seconds, etc. Most real congestion problems come before this frame is generated. (read: before a new channel is up at all) So if this patch should be applied, maybe it should be configurable, or let out.



--
This message was sent by Atlassian JIRA
(v6.2#6252)