[asterisk-bugs] [JIRA] (ASTERISK-26603) [patch] chan_pjsip: not switching sending codec to receiving codec when asymmetric_rtp_codec=no

[Alexei Gradinari (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-26603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=235082#comment-235082 ] 

Alexei Gradinari commented on ASTERISK-26603:
---------------------------------------------

Daniel,

I see you mixing SIP and PJSIP.
I don't think it's good idea.
Anyway this patch was tested only with PJSIP.


> [patch] chan_pjsip: not switching sending codec to receiving codec when asymmetric_rtp_codec=no
> -----------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-26603
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26603
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_pjsip
>    Affects Versions: GIT
>            Reporter: Alexei Gradinari
>            Assignee: Alexei Gradinari
>      Target Release: 13.14.0, 14.3.0
>
>         Attachments: debug.txt, record.wav
>
>
> The patch https://gerrit.asterisk.org/#/c/4172/ introduced a new option 'asymmetric_rtp_codec' to disable asymmetric codecs for sending
> and receiving.
> But it makes incorrectly.
> The sending codec is switched to the receiving codec and then is switched back to the best native codec on EVERY receiving RTP packets.
> This is because after call of ast_channel_set_rawwriteformat there is call
> of ast_set_write_format which calls set_format which sets rawwriteformat to the best native format.



--
This message was sent by Atlassian JIRA
(v6.2#6252)