[asterisk-bugs] [JIRA] (ASTERISK-20533) Odd happenings in inotify and kqueue code with spool files.

[Joshua Colp (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-20533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joshua Colp updated ASTERISK-20533:
-----------------------------------

    Severity: Minor  (was: Major)

> Odd happenings in inotify and kqueue code with spool files.
> -----------------------------------------------------------
>
>                 Key: ASTERISK-20533
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20533
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: PBX/pbx_spool
>    Affects Versions: 1.8.18.0, 13.18.4
>            Reporter: Richard Mudgett
>            Severity: Minor
>
> While working on ASTERISK-17231 I came across some odd behavior.  When INOTIFY and KQUEUE support was added, a warning message was conditionaled out.  I added the todo comment to indicate that something strange is going on.  Further investigation is needed to determine if there is a better way to do this since call files may be processed erroneously.
> {code:title=pbx/pbx_spool.c}
> 	/* Attempt to open the file */
> 	f = fopen(o->fn, "r");
> 	if (!f) {
> #if defined(HAVE_INOTIFY) || defined(HAVE_KQUEUE)
> 		/*!
> 		 * \todo XXX There is some odd delayed duplicate servicing of
> 		 * call files going on.  We need to suppress the error message
> 		 * if the file does not exist as a result.
> 		 */
> 		if (errno != ENOENT)
> #endif
> 		{
> 			ast_log(LOG_WARNING, "Unable to open %s: '%s'(%d), deleting\n",
> 				o->fn, strerror(errno), (int) errno);
> 		}
> 		remove_from_queue(o, "Failed");
> 		free_outgoing(o);
> 		return -1;
> 	}
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)