[asterisk-bugs] [JIRA] (ASTERISK-12379) [PATCH] duplicate code for setting LSPI

[Corey Farrell (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-12379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Corey Farrell updated ASTERISK-12379:
-------------------------------------

    Assignee: Mark Wilkinson
      Status: Waiting for Feedback  (was: Open)

Are you interested in pursuing this further?  If so the patch will need to be rebased so it can apply the the current {{master}} branch and it will need to go through code review.

----

Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review \[1\] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines \[2\]
* Review the Code Review Checklist \[3\] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch \[4\]

When ready, submit your patch and any tests to Gerrit \[5\] for code review.

Thanks!

\[1\] https://wiki.asterisk.org/wiki/display/AST/Code+Review
\[2\] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
\[3\] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
\[4\] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
\[5\] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage

> [PATCH] duplicate code for setting LSPI
> ---------------------------------------
>
>                 Key: ASTERISK-12379
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-12379
>             Project: Asterisk
>          Issue Type: Bug
>          Components: Channels/chan_dahdi/NewFeature, Channels/chan_dahdi/SS7
>            Reporter: Mark Wilkinson
>            Assignee: Mark Wilkinson
>            Severity: Minor
>         Attachments: dahdi-dup_code.patch, dahdi-dup_code-v2.patch
>
>
> After talking with Matthew and Alan via E-mail, I noticed in chan_dahdi.c there are 2 near identical calls to set the SS7 LSPI parameters dependant on channel variables SS7_RLT_ON and SS7_LSPI_IDENT
> code begins around line 2455 in chan_dahdi.c
> ****** ADDITIONAL INFORMATION ******
> I have a patch, which removes the duplicate code, and alters the channel variable slightly to allow the setting of not just the LSPI Ident, but the Type, Scheme & Context - This may be of use for getting the RLT to work with PBX's other than Nortel.



--
This message was sent by Atlassian JIRA
(v6.2#6252)