[asterisk-bugs] [JIRA] (ASTERISK-27216) app_queue: does its check-makeannouncement-logic twice each head-caller-loop

[Stefan Engström (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=238338#comment-238338 ] 

Stefan Engström edited comment on ASTERISK-27216 at 8/31/17 2:23 AM:
---------------------------------------------------------------------

The issue with say_position and say_periodic_announcement are very similar. 

Also a key point I'm making (what I meant with 'uneccessary commit') is that reverting that old commit I link preserves the good behavior (the behaviour i expect asterisk to have had up til 2013) that all positioninfo and announcements to head callers are still played, but only between the ringing phases. But of course I invite everyone to review side effects of reverting that commit.

I noticed that the commit in question had a commit message saying something like "without this commit head caller will not hear announcements", which is not true anymore by my tests. (But maybe it was when the commit was made?)



was (Author: stefaneng86):
The issue with say_position and say_periodic_announcement are very similar. 

Also a key point I'm making (what I meant with 'uneccessary commit') is that reverting that old commit I link preserves the good behavior (the behaviour i expect asterisk to have had up til 2013) that all positioninfo and announcements to head callers are still played, but only between the ringing phases. But of course I invite everyone to review side effects of reverting that commit.

I noticed that the commit in question had a commit message saying something like "without this commit head caller will not hear announcements", which is not true by my tests.


> app_queue: does its check-makeannouncement-logic twice each head-caller-loop
> ----------------------------------------------------------------------------
>
>                 Key: ASTERISK-27216
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27216
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_queue
>    Affects Versions: 13.15.0
>            Reporter: Stefan Engström
>            Severity: Minor
>
> I think the addition of the second check via the commit in 
> https://reviewboard.asterisk.org/r/2263/
> is unnecessary,
> By putting a check there, it allows for the possibility for the agent's phones to be ringing while announcement information is being played out to the head caller. Announcements should only be played between ringing cycles?



--
This message was sent by Atlassian JIRA
(v6.2#6252)