[asterisk-bugs] [JIRA] (ASTERISK-27216) app_queue: does its check-makeannouncement-logic twice each head-caller-loop

[Benjamin Keith Ford (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=238321#comment-238321 ] 

Benjamin Keith Ford commented on ASTERISK-27216:
------------------------------------------------

Hey Stefan,
If you look at the queues.conf sample file and search "announce-frequency" and "periodic-announce", you can find these descriptions:
{quote}
; How often to announce queue position and/or estimated
; holdtime to caller (0=off)
; Note that this value is ignored if the caller's queue
; position has changed (see min-announce-frequency)
;
;announce-frequency = 90

;periodic-announce = queue-periodic-announce
;
; A set of periodic announcements can be defined by separating
; periodic announcements to reproduce by commas. For example:
;periodic-announce = queue-periodic-announce,your-call-is-important,please-wait
;
; The announcements will be played in the order in which they are defined. After
; playing the last announcement, the announcements begin again from the beginning.
{quote}
This seems to be inline with the source code, since they are checks for two different types of announcements. Is there a bug you've run into? If so, please post it along with the steps you took so we can reproduce it. Thanks!

> app_queue: does its check-makeannouncement-logic twice each head-caller-loop
> ----------------------------------------------------------------------------
>
>                 Key: ASTERISK-27216
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27216
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_queue
>    Affects Versions: 13.15.0
>            Reporter: Stefan Engström
>            Severity: Minor
>
> I think the addition of the second check via the commit in 
> https://reviewboard.asterisk.org/r/2263/
> is unnecessary,
> By putting a check there, it allows for the possibility for the agent's phones to be ringing while announcement information is being played out to the head caller. Announcements should only be played between ringing cycles?



--
This message was sent by Atlassian JIRA
(v6.2#6252)