[asterisk-bugs] [JIRA] (ASTERISK-26919) res_pjsip_dialog_info_body_generator: Ringing&&InUse behavior difference between chan_sip and res_pjsip

[Zach R (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-26919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=236550#comment-236550 ] 

Zach R edited comment on ASTERISK-26919 at 4/14/17 3:18 PM:
------------------------------------------------------------

Sorry for the late reply got held up with some other stuff.  I've opened a pull request/patch on Gerrit following the instructions you linked. As well I cherry picked it via the website rather than terminal for the cherry pick to 14 and master if that matters. If it does I can redo it following the cherry pick terminal instructions.


was (Author: zrothy):
Sorry for the late reply got held up with some other projects. Sure, I've opened a pull request/patch on Gerrit following the instructions you linked. As well I cherry picked it via the website rather than terminal for the cherry pick to 14 and master if that matters. If it does I can redo it following the cherry pick terminal instructions.

> res_pjsip_dialog_info_body_generator: Ringing&&InUse behavior difference between chan_sip and res_pjsip
> -------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-26919
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26919
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip_dialog_info_body_generator
>    Affects Versions: 13.7.0
>         Environment: CentOS release 6.6 (Final)
> Working off git branch 13.  Version: GIT-13-73cbb91 
>            Reporter: Zach R
>            Assignee: Unassigned
>            Severity: Minor
>         Attachments: ringing_in_use_pickup.patch
>
>
> Previously on asterisk 1.8 with chan_sip the dialog body of a notify for a device that was Ringing&&InUse had its state set to early in the dialog body. With Asterisk 13, using PJSIP as the channel driver it is sending "Completed".  Due to the state being completed, I found that Cisco SPA series phones monitoring a hint won't flash as expected for Ringing&&InUse states.
> I was able to resolve this by changing completed to early within /res/res_pjsip/presence_xml.c inside the method "ast_sip_presence_exten_state_to_str".
> After patching this I found a related bug which was not allowing a BLF on the SPA phones to do directed pickup from the Ringing&&InUse device it monitored.. 
> Previously it was patched so that for the ringing state in /res/res_pjsip_dialog_info_body_generator.c, method 'dialog_info_generate_body_content', added a direction node to the xml dialog. This is not added during Ringing&&InUse as the if statement that adds it only checks for the state being ringing. After modifying the if statement a bit so it added it, I was able to get teh directed pickup to work as it had done in earlier versions of asterisk.



--
This message was sent by Atlassian JIRA
(v6.2#6252)