[asterisk-bugs] [JIRA] (ASTERISK-23989) [patch]SDP offer/answer fails if crypto keys added to non-crypto offer

[Walter Doekes (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=232154#comment-232154 ] 

Walter Doekes commented on ASTERISK-23989:
------------------------------------------

Git reviews:

https://gerrit.asterisk.org/#/c/3234/ <-- by Alexander Traud, does the inverse and accepts the SRTP
https://gerrit.asterisk.org/#/c/3828/ <-- by me, a more complete version of sdes-rtp-avp.diff

> [patch]SDP offer/answer fails if crypto keys added to non-crypto offer
> ----------------------------------------------------------------------
>
>                 Key: ASTERISK-23989
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23989
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/SRTP
>    Affects Versions: 1.8.28.2
>         Environment: Planet earth
>            Reporter: Olle Johansson
>         Attachments: sdes-rtp-avp.diff
>
>
> 1) We got a new SNOM phone configured so it offered RTP/AVP but for some reason added a=crypto SDES keys. 
> 2) Microsoft Lync offers RTP/AVP and optional RTP/SAVP in the same SDP, also adding keys if RTP/SAVP is accepted
> Asterisk fails offer answer with the message:
> "We are requesting SRTP for audio, but they responded without it!"
> and sends 488. This error message is wrong and failing is wrong.
> We should ignore non-relevant attributes. If RTP/AVP is the offer, just don't check for the crypto keys and activate p->srtp.



--
This message was sent by Atlassian JIRA
(v6.2#6252)