[asterisk-bugs] [JIRA] (ASTERISK-26529) [UBSAN] codec_adpcm.c: runtime error: left shift of negative value -4

[Corey Farrell (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-26529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Corey Farrell closed ASTERISK-26529.
------------------------------------

    Resolution: Not A Bug

This is not necessarily a bug.  Left shift of a negative value may not make sense from human mathematical rules, but that doesn't automatically make it invalid for a computer algorithm.

For this ticket to be reopened I would want to see a reproducible example of the codec translation introducing an audio problem (distortion, clicks, change of audio tone).  Without proof of a real world problem the risk of changing this is too high.

> [UBSAN] codec_adpcm.c: runtime error: left shift of negative value -4
> ---------------------------------------------------------------------
>
>                 Key: ASTERISK-26529
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26529
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>    Affects Versions: 13.12.1, 14.1.1, GIT
>            Reporter: Badalian Vyacheslav
>            Severity: Minor
>
> {code}
> codec_adpcm.c:151:23: runtime error: left shift of negative value -4
>     #0 0x7fe47d1753b0  (/tmp/asterisk-testsuite/86ef220a01cc7fa06596ddd595bec9bf/run_1/ast1/usr/lib/asterisk/modules/codec_adpcm.so+0x53b0)
>     #1 0x7fe47d175673  (/tmp/asterisk-testsuite/86ef220a01cc7fa06596ddd595bec9bf/run_1/ast1/usr/lib/asterisk/modules/codec_adpcm.so+0x5673)
>     #2 0x7fe47d1762cb  (/tmp/asterisk-testsuite/86ef220a01cc7fa06596ddd595bec9bf/run_1/ast1/usr/lib/asterisk/modules/codec_adpcm.so+0x62cb)
>     #3 0x962eca in generate_computational_cost /usr/src/asterisk/main/translate.c:674
>     #4 0x96857e in __ast_register_translator /usr/src/asterisk/main/translate.c:1217
>     #5 0x7fe47d17667d  (/tmp/asterisk-testsuite/86ef220a01cc7fa06596ddd595bec9bf/run_1/ast1/usr/lib/asterisk/modules/codec_adpcm.so+0x667d)
>     #6 0x76089c in start_resource /usr/src/asterisk/main/loader.c:1029
>     #7 0x763941 in load_resource_list /usr/src/asterisk/main/loader.c:1293
>     #8 0x764e6e in load_modules /usr/src/asterisk/main/loader.c:1454
>     #9 0x4bf34f in asterisk_daemon /usr/src/asterisk/main/asterisk.c:4616
>     #10 0x4be642 in main /usr/src/asterisk/main/asterisk.c:4373
>     #11 0x7fe4ad989b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
>     #12 0x433918  (/usr/sbin/asterisk+0x433918)
> {code}
> {code}
> root at 0bfa9456f68a:/usr/src/asterisk# git log
> commit 6b1c55dc9be90904363dbcf958a9fcc243c85629
> Author: George Joseph <gjoseph at digium.com>
> Date:   Fri Oct 28 15:59:19 2016 -0600
>     pjproject_bundled:  Fix issue where "/version.mak" wasn't found
> root at 0bfa9456f68a:/usr/src/asterisk# git branch
> * 13
> {code}
> on module load...



--
This message was sent by Atlassian JIRA
(v6.2#6252)