[asterisk-bugs] [JIRA] (ASTERISK-26603) chan_pjsip: not switching sending codec to receiving codec when asymmetric_rtp_codec=no

[Alexei Gradinari (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-26603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Gradinari updated ASTERISK-26603:
----------------------------------------

    Description: 
The patch https://gerrit.asterisk.org/#/c/4172/ introduced a new option 'asymmetric_rtp_codec' to disable asymmetric codecs for sending
and receiving.
But it makes incorrectly.
The sending codec is switched to the receiving codec and then is switched back to the best native codec on EVERY receiving RTP packets.

This is because after call of ast_channel_set_rawwriteformat there is call
of ast_set_write_format which calls set_format which sets rawwriteformat to the best native format.


  was:
The patch https://gerrit.asterisk.org/#/c/4172/ introduced a new option 'asymmetric_rtp_codec' to disable asymmetric codecs for sending
and receiving.
But it makes incorrectly.
The sending codec is switched to the receiving codec and then is switched back to the best native codec on EVERY receiving RTP packets.

This is because after call of ast_channel_set_rawwriteformat there is call
of ast_set_write_format which calls set_format which sets rawwriteformat to the best native format.

The patch removes call of ast_set_write_format which is not necessary.


        Summary: chan_pjsip: not switching sending codec to receiving codec when asymmetric_rtp_codec=no  (was: [patch] chan_pjsip: not switching sending codec to receiving codec when asymmetric_rtp_codec=no)

> chan_pjsip: not switching sending codec to receiving codec when asymmetric_rtp_codec=no
> ---------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-26603
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26603
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_pjsip
>    Affects Versions: GIT
>            Reporter: Alexei Gradinari
>
> The patch https://gerrit.asterisk.org/#/c/4172/ introduced a new option 'asymmetric_rtp_codec' to disable asymmetric codecs for sending
> and receiving.
> But it makes incorrectly.
> The sending codec is switched to the receiving codec and then is switched back to the best native codec on EVERY receiving RTP packets.
> This is because after call of ast_channel_set_rawwriteformat there is call
> of ast_set_write_format which calls set_format which sets rawwriteformat to the best native format.



--
This message was sent by Atlassian JIRA
(v6.2#6252)