[asterisk-bugs] [JIRA] (ASTERISK-26580) [patch] Error during LDAP modify action when user unregisters

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-26580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=233657#comment-233657 ] 

Rusty Newton commented on ASTERISK-26580:
-----------------------------------------

Thanks! I have two comments.

One is that bug fixes are no longer accepted to 11. 11 now accepts only security fixes. You can see the life cycles for the Asterisk versions here: https://wiki.asterisk.org/wiki/display/AST/Asterisk+Versions

You'll want to make sure your patch works on 13 and 14, then cherry-pick it to the correct versions and remove it for 11. Cherry-pick it to the branches, not specific versioned tags.

https://wiki.asterisk.org/wiki/display/AST/Code+Review

The second is that the commit message could use a little modification. It should stand on its own with a description. So you might use some of what you had for the description on this ticket.

See the example at the bottom of this page: https://wiki.asterisk.org/wiki/display/AST/Commit+Messages

> [patch] Error during LDAP modify action when user unregisters
> -------------------------------------------------------------
>
>                 Key: ASTERISK-26580
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26580
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_config_ldap
>    Affects Versions: 11.24.1
>         Environment: 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux
> slapd 2.4.40+dfsg-1+deb8u2
>            Reporter: Nicholas John Koch
>            Severity: Minor
>         Attachments: res_config_ldap.c-11.24.1.patch
>
>
> When an account has been looked up from the LDAP directory and activated some values within the LDAP object (AsteriskSIPUser) are updated.
> In this special case we are looking at _AstAccountFullContact_. When this account now unregisters the LDAP object will be updated.
> During this process some attributes get deleted. The bug is that the first attribute in the list is trying to be modified without a value but it should be deleted instead.
> Wiresharking the issue showed that the LDAP modification command has an empty value which is in terms of the LDAP syntax a fault.
> Hence this modification command must be a deletion.
> The patch checks if the first new value ist empty (mostly _AstAccountFullContact_) and therefore inserts a deletion command rather than a modification command. A similar
> procedure is already done some lines below but has not been implemented to the first name/value pair.



--
This message was sent by Atlassian JIRA
(v6.2#6252)