[asterisk-bugs] [JIRA] (ASTERISK-26562) Transmit Silence on ControlPlayback pause

[Asterisk Team (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-26562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=233441#comment-233441 ] 

Asterisk Team commented on ASTERISK-26562:
------------------------------------------

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

> Transmit Silence on ControlPlayback pause
> -----------------------------------------
>
>                 Key: ASTERISK-26562
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26562
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Applications/app_controlplayback
>    Affects Versions: 13.12.1
>         Environment: Debian jessie/sid
>            Reporter: Mikheili Dautashvili
>
> It's a good idea if Asterisk would be able to transmit silence when pausing ControlPlayback application.
> Currently it stops transmiting RTP stream, though transmit_silence = yes is enabled in asterisk.conf
> Tested only for 13.12.1 version. 
> Bellow is a patch that fix this issue.
> {code}
> --- app.c.orig  2016-11-07 06:14:26.017973000 -0500
> +++ app.c       2016-11-07 06:06:13.889973000 -0500
> @@ -1074,6 +1074,8 @@
>         long pause_restart_point = 0;
>         long offset = 0;
> +   struct ast_silence_generator *silgen = NULL;
> +
>         if (!file) {
>                 return -1;
>         }
> @@ -1161,6 +1163,9 @@
>                 if ((suspend && strchr(suspend, res)) || res == AST_CONTROL_STREAM_SUSPEND) {
>                         pause_restart_point = ast_tellstream(ast_channel_stream(chan));
> +         if (ast_opt_transmit_silence) {
> +            silgen = ast_channel_start_silence_generator(chan);
> +         }
>                         ast_test_suite_event_notify("PLAYBACK","Channel: %s\r\n"
>                                 "Control: %s\r\n",
>                                 ast_channel_name(chan),
> @@ -1171,6 +1176,9 @@
>                                         continue;
>                                 } else if (res == -1 || (suspend && strchr(suspend, res)) || (stop && strchr(stop, res))
>                                                 || res == AST_CONTROL_STREAM_SUSPEND || res == AST_CONTROL_STREAM_STOP) {
> +               if (silgen) {
> +                  ast_channel_stop_silence_generator(chan, silgen);
> +               }
>                                         break;
>                                 }
>                         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)