[asterisk-bugs] [JIRA] (ASTERISK-26007) res_pjsip: Endpoints deleting early after upgrade from 13.8.2 to 13.9

[Mark Michelson (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-26007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=230594#comment-230594 ] 

Mark Michelson commented on ASTERISK-26007:
-------------------------------------------

All right, I have this figured out now. There are a couple of reviews up on gerrit now for this:

https://gerrit.asterisk.org/#/c/2819/

This fixes an issue where we were attempting to retrieve all contacts whose expiration was prior to now. The problem is that the conversion of times from string to float was losing the least significant bits, resulting in wrong values being used. This resulted in contacts matching this criterion well before they were set to be retrieved. However, this is not the only thing that was wrong. Even if a contact were retrieved early, there was a second comparison of the current time to the time on the contact.

https://gerrit.asterisk.org/#/c/2821/

The problem here is that objects retrieved from the astdb were all messed up. We would retrieve a contact and set its expiration to 0, rather than the actual timestamp when it was set to expire. So, because of the first issue, we'd retrieve the contact earlier than we were supposed to. Then we'd perform the second time comparison and see that we're WAY beyond when the contact was supposed to expire, so we'd delete it. This second issue is actually fixed in the 13 branch in the commit you pointed out in your previous comment. The review linked here is for the 13.9 branch and contains only the bug fix without the rest of the content of the commit in the 13 branch.

Once these have been merged, we will create a 13.9.1 regression release.

> res_pjsip: Endpoints deleting early after upgrade from 13.8.2 to 13.9
> ---------------------------------------------------------------------
>
>                 Key: ASTERISK-26007
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26007
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip
>    Affects Versions: 13.9.0
>         Environment: FreePBX Distro 10.13.66-11 - Fully patched running Edge Track
> System runs as a VM on ESXi 6.0u2 - 1 Processor 4 GB RAM 
> Endpoints (connecting using PJSIP) consist of 2 x Polycom 335, 1 x Polycom 450 and 1 x Polycom 670, 1 x Gigaset N510 IP Pro & 1 x Mobotix Doorstation T25.  All of the endpoints are connected to the same subnet as the FreePBX box (except the Mobotix).
>            Reporter: Greg Siemon
>            Assignee: Mark Michelson
>         Attachments: asterisk full, git-bisect-bad-13.8.2-13.9.txt, PJSIP Config Files.zip, pjsip-expiry-error.txt, pjsip set logger on
>
>
> System works without issues on Asterisk 13.8.2.
> After updating to 13.9 I find all of the endpoints start dropping out of Asterisk (logs and PJSIP config files attached).  
> Moving back to 13.8.2 solves the issue.



--
This message was sent by Atlassian JIRA
(v6.2#6252)