[asterisk-bugs] [JIRA] (ASTERISK-25917) [patch]app_voicemail: passwordlocation=spooldir only works if you manually add secret.conf yourself

[Jonathan R. Rose (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=230461#comment-230461 ] 

Jonathan R. Rose edited comment on ASTERISK-25917 at 5/2/16 12:42 PM:
----------------------------------------------------------------------

I notice the issue is still open, so I'm going to go ahead and give a quick break down of what has happened so that whoever ends up seeing it through knows the situation...

https://gerrit.asterisk.org/#/q/topic:ASTERISK-25917

George Joseph had a patch up on Gerrit that was accepted and committed to 11, 13, and master. George's patch also includes an internal test that verifies config file saving behavior. I've confirmed that this patch fixes the issue.

I also have a patch up on Gerrit for the Asterisk testsuite. It's a test that uses a somewhat older voicemail testing system and specifically verifies that the password will be saved to the right file on a fresh system when using passwordlocation=spooldir. Asterisk sends a specific test event for when the password is saved using spooldir, so that event is checked along with the contents of the saved secret.conf file that goes in the spool directory. That patch has not yet been reviewed. Once that has been either accepted or rejected, this issue will be resolved.


was (Author: jonathanrose):
I notice the issue is still open, so I'm going to go ahead and give a quick break down of what has happened so that whoever ends up seeing it through knows the situation...

https://gerrit.asterisk.org/#/q/topic:ASTERISK-25917

George Joseph had a patch up on Gerrit that was accepted and committed to 11, 13, and master. George's patch also includes an internal test that verifies config file saving behavior.

I also have a patch up on Gerrit for the Asterisk testsuite. It's a test that uses a somewhat older voicemail testing system and specifically verifies that the password will be saved to the right file on a fresh system when using passwordlocation=spooldir. Asterisk sends a specific test event for when the password is saved using spooldir, so that event is checked along with the contents of the saved secret.conf file that goes in the spool directory. That patch has not yet been reviewed. Once that has been either accepted or rejected, this issue will be resolved.

> [patch]app_voicemail: passwordlocation=spooldir only works if you manually add secret.conf yourself
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-25917
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25917
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_voicemail
>    Affects Versions: 11.22.0-rc1, 13.8.0-rc1
>            Reporter: Jonathan R. Rose
>            Assignee: George Joseph
>         Attachments: asterisk_write_new_config.diff
>
>
> Long time no patch.
> passwordlocation=spooldir is a general section option in voicemail.conf that makes changed voicemail passwords be stored in a secret.conf file within the individual mailbox folders rather than writing the change directly to voicemail.conf
> I tracked this feature back to 1.8 which is the first version where it was implemented. It doesn't work in the final version of 1.8 or in any version since because ast_config_text_file_save won't write new files. It exits early on account of failing an access check against the file that doesn't exist yet.
> I've written a very simple patch against Asterisk 11 that just adds a check for when the file doesn't exist and skips the check against read and write access check if that's the case. I'll be attaching the patch to the issue, and hopefully my new contributor agreement will be authorized soon.



--
This message was sent by Atlassian JIRA
(v6.2#6252)