[asterisk-bugs] [JIRA] (ASTERISK-25070) Fix FTBFS on Hurd

[Tzafrir Cohen (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-25070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tzafrir Cohen reopened ASTERISK-25070:
--------------------------------------


I'll note that the patch includes two separate parts:

1. setting PATH_MAX to 4096 explicitly if it is not already defined (which practically means that it is the HURD).

2. Fixing Makefile and main/netsock.c to build properly on the HURD.

(2) is trivial (there's basically one way to do it), and I'll re-submit it myself.

Likewise (1) seems trivial. The only issue it raises is: what happens if then on a HURD system the system hands asterisk a path longer than 4096 bytes?

Well, you can easily do that on Linux (PATH_MAX is practically an arbitrary size and not an actual limitation. The kernel is not bound by it . Bash, for instance, ignores it). I did some very initial tests and was not able to crash Asterisk in any way. So I'd say it's safe. Is it OK to submit reviews for both issues?

> Fix FTBFS on Hurd
> -----------------
>
>                 Key: ASTERISK-25070
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25070
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>    Affects Versions: 13.1.0
>         Environment: Debian sid hurd-i386
>            Reporter: Gabriele Giacone
>            Severity: Minor
>
> Patch in URL field fixes asterisk build on Hurd.
> Not signed CLA because tiny patch, not legally significant.
> Thanks for considering
> \[EDIT\]: Removed linked to external patch. Patches must either be attached to the issue, or preferably, submitted to Gerrit [https://gerrit.asterisk.org].
> - mjordan



--
This message was sent by Atlassian JIRA
(v6.2#6252)