[asterisk-bugs] [JIRA] (ASTERISK-25830) Revision 2451d4e breaks NAT

[George Joseph (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-25830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Joseph closed ASTERISK-25830.
------------------------------------

    Resolution: Fixed

> Revision 2451d4e breaks NAT
> ---------------------------
>
>                 Key: ASTERISK-25830
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25830
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip_nat
>    Affects Versions: SVN
>            Reporter: Sean Bright
>            Assignee: George Joseph
>            Severity: Blocker
>      Target Release: 13.8.0
>
>         Attachments: sanitized-transport-and-endpoint-configs.conf
>
>
> {noformat}
> 18:01 <@seanbright> gtjoseph: 2451d4e breaks NAT for me (found with 'git bisect')
> 18:02 <@seanbright> the Contact header is not being rewritten by res_pjsip_nat
> 18:03 <@seanbright> i believe one or more of the comparisons in res_pjsip_nat.c:find_transport_state_in_use() are incorrect
> 18:03 <@seanbright> simple setup - asterisk behind NAT, itsp on the public iternet
> 18:04 <@seanbright> Contact header contains private IP
> 18:04 < gtjoseph> endpoint rewrite_contact is yes?
> 18:04 <@seanbright> gtjoseph: it is not, no
> 18:04 <@seanbright> gtjoseph: even if it is, it doesn't change anything
> 18:05 <@seanbright> gtjoseph: i have the same setup with a pre-2451d4e (no rewrite_contact) and it works correctly
> 18:05 <@seanbright> i'm fairly certain that the pointer comparison on (current) line 161 is bogus
> 18:05 <@seanbright> details->transport == transport_state->transport
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)