[asterisk-bugs] [JIRA] (ASTERISK-25721) [patch] memory leak and heap-use-after-free in res_phoneprov

[Badalian Vyacheslav (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=229140#comment-229140 ] 

Badalian Vyacheslav edited comment on ASTERISK-25721 at 1/23/16 3:06 AM:
-------------------------------------------------------------------------

second patch fixes this

{code}
==23039==ERROR: AddressSanitizer: heap-use-after-free on address 0x60c000c7feb9 at pc 0x7f658554d17e bp 0x7ffeda1ccff0 sp 0x7ffeda1ccfe0
READ of size 1 at 0x60c000c7feb9 thread T0
    #0 0x7f658554d17d in _ast_strlen_zero /root/asterisk-13.7.0/include/asterisk/strings.h:54
    #1 0x7f6585555eca in get_defaults /root/asterisk-13.7.0/res/res_phoneprov.c:1239
    #2 0x7f658555631b in load_users /root/asterisk-13.7.0/res/res_phoneprov.c:1281
    #3 0x7f65855576e8 in ast_phoneprov_provider_register /root/asterisk-13.7.0/res/res_phoneprov.c:1552
    #4 0x7f6585556d5d in load_module /root/asterisk-13.7.0/res/res_phoneprov.c:1443
    #5 0x669fda in start_resource /root/asterisk-13.7.0/main/loader.c:1021
    #6 0x66b88e in load_resource_list /root/asterisk-13.7.0/main/loader.c:1219
    #7 0x66c58e in load_modules /root/asterisk-13.7.0/main/loader.c:1367
    #8 0x49344d in asterisk_daemon /root/asterisk-13.7.0/main/asterisk.c:4676
    #9 0x4923db in main /root/asterisk-13.7.0/main/asterisk.c:4282
    #10 0x7f658b42bb14 in __libc_start_main (/lib64/libc.so.6+0x21b14)
    #11 0x432ae8  (/usr/sbin/asterisk+0x432ae8)

{code}

ponter was deleted becouse {cfg} destroyed



was (Author: slavon):
second patch fixes this

{code}
==23039==ERROR: AddressSanitizer: heap-use-after-free on address 0x60c000c7feb9 at pc 0x7f658554d17e bp 0x7ffeda1ccff0 sp 0x7ffeda1ccfe0
READ of size 1 at 0x60c000c7feb9 thread T0
    #0 0x7f658554d17d in _ast_strlen_zero /root/asterisk-13.7.0/include/asterisk/strings.h:54
    #1 0x7f6585555eca in get_defaults /root/asterisk-13.7.0/res/res_phoneprov.c:1239
    #2 0x7f658555631b in load_users /root/asterisk-13.7.0/res/res_phoneprov.c:1281
    #3 0x7f65855576e8 in ast_phoneprov_provider_register /root/asterisk-13.7.0/res/res_phoneprov.c:1552
    #4 0x7f6585556d5d in load_module /root/asterisk-13.7.0/res/res_phoneprov.c:1443
    #5 0x669fda in start_resource /root/asterisk-13.7.0/main/loader.c:1021
    #6 0x66b88e in load_resource_list /root/asterisk-13.7.0/main/loader.c:1219
    #7 0x66c58e in load_modules /root/asterisk-13.7.0/main/loader.c:1367
    #8 0x49344d in asterisk_daemon /root/asterisk-13.7.0/main/asterisk.c:4676
    #9 0x4923db in main /root/asterisk-13.7.0/main/asterisk.c:4282
    #10 0x7f658b42bb14 in __libc_start_main (/lib64/libc.so.6+0x21b14)
    #11 0x432ae8  (/usr/sbin/asterisk+0x432ae8)

{code}

> [patch] memory leak and heap-use-after-free in res_phoneprov
> ------------------------------------------------------------
>
>                 Key: ASTERISK-25721
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25721
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_phoneprov
>    Affects Versions: 13.7.0
>            Reporter: Badalian Vyacheslav
>         Attachments: res_phoneprov2.diff, res_phoneprov.diff
>
>
> fonded and tested in asan



--
This message was sent by Atlassian JIRA
(v6.2#6252)