[asterisk-bugs] [JIRA] (ASTERISK-26659) pjsip presence missing tags in XML

[snuffy (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-26659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=234229#comment-234229 ] 

snuffy commented on ASTERISK-26659:
-----------------------------------

Hello,

Please test this patch, it should apply to 13.

Altered the res/res_pjsip_pidf_eyebeam_body_supplement.c that handles the creation of the xml.


> pjsip presence missing tags in XML
> ----------------------------------
>
>                 Key: ASTERISK-26659
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26659
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip_pidf_eyebeam_body_supplement
>    Affects Versions: 13.11.2
>         Environment: Linux version 2.6.32-504.8.1.el6.x86_64 (mockbuild at c6b9.bsys.dev.centos.org) (gcc version 4.4.7 20120313 (Red Hat 4.4.7-11) (GCC) ) #1 SMP Wed Jan 28 21:11:36 UTC 2015
>            Reporter: Abraham Liebsch
>            Severity: Minor
>
> It appears that the XML for setting presence in Eyebeam/X-Lite per RFC is missing braces around the status element.  The result is that presence is not properly communicated to the client.  Idle properly reads as "Available" but any other status is received as "Offline".
> Example of current output from the client log which should set extension 71 presence to "on the phone" but results in it showing as offline:
> {code:xml}
> NOTIFY sip:335 at 10.255.4.178:60424;rinstance=8e8e55168a09d83d SIP/2.0
> Via: SIP/2.0/UDP 10.255.1.18:5060;rport=5060;branch=z9hG4bKPj2.lz1iVzKL4AQLjI4tg97nxztTUfX3up
> Max-Forwards: 70
> Contact: <sip:10.255.1.18:5060>
> To: <sip:335 at pbx.example.com>;tag=4a390f4c
> From: <sip:71 at pbx.example.com>;tag=aQ0ijmdmPLUEQ5hi73BKM4hAE9KSFutx
> Call-ID: 82158Yzk2MmNlMDlkMDMzYjk3MzdjNmQyYzQ2ZDkwYmE5NzY
> CSeq: 23753 NOTIFY
> Content-Type: application/pidf+xml
> User-Agent: FPBX-13.0.190.7(13.11.2)
> Subscription-State: active;expires=3561
> Event: presence
> Allow-Events: presence, dialog, message-summary, refer
> Content-Length: 558
> <?xml version="1.0" encoding="UTF-8"?>  
> <presence entity="sip:71 at 10.255.1.18:5060" xmlns="urn:ietf:params:xml:ns:pidf" xmlns:pp="urn:ietf:params:xml:ns:pidf:person" xmlns:es="urn:ietf:params:xml:ns:pidf:rpid:status:rpid-status" xmlns:ep="urn:ietf:params:xml:ns:pidf:rpid:rpid-person">  
>  <note>On the phone</note>  
>  <tuple id="71">  
>   <status>  
>    <basic>closed</basic>  
>   </status>  
>   <contact priority="1"><sip:335 at pbx.example.com></contact>  
>  </tuple>  
>  <pp:person>  
>   <status>  
>    <ep:activities>ep:busy</ep:activities>  
>   </status>  
>  </pp:person>  
> </presence>
> {code}
> It seems per https://tools.ietf.org/html/rfc4480#section-3.2 that the line
> {code:xml}
>    <ep:activities>ep:busy</ep:activities>  
> {code}
> should actually be
> {code:xml}
>    <ep:activities><ep:busy/></ep:activities>  
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)