[asterisk-bugs] [JIRA] (ASTERISK-26317) pjsip PJMEDIA_SDP_NEG_ANSWER_MULTIPLE_CODECS always defined.

[Joshua Colp (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-26317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joshua Colp closed ASTERISK-26317.
----------------------------------

    Resolution: Suspended

This would be considered a feature request and if a patch is created you can reopen this issue and attach it.

As for the #ifdef in question that tests the presence of the pjmedia_sdp_neg_set_answer_multiple_codecs function. This was a contribution we made to PJSIP and did not exist before the Asterisk work was done. To ensure Asterisk still built without a version that supported it a check was added. It does not, and is not supposed to, control whether they are enabled or not. It's always supposed to be currently if the function is available like you've seen.

> pjsip PJMEDIA_SDP_NEG_ANSWER_MULTIPLE_CODECS always defined.
> ------------------------------------------------------------
>
>                 Key: ASTERISK-26317
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26317
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: pjproject/pjsip
>    Affects Versions: 13.8.0
>         Environment: CentOS 6.5
>            Reporter: Aaron An
>            Severity: Critical
>
> look at res/res_pjsip_session.c function "new_invite()" or "ast_sip_session_create_invite()", 
> #ifdef PJMEDIA_SDP_NEG_ANSWER_MULTIPLE_CODECS
>  pjmedia_sdp_neg_set_answer_multiple_codecs(session->inv_session->neg, PJ_TRUE);
> #endif
> but in pjproject it alway define PJMEDIA_SDP_NEG_ANSWER_MULTIPLE_CODECS to 0 or other. so we always set the multiple codecs to true.
> I think it will be better to have a set in pjsip.conf to control where use multiple codecs.



--
This message was sent by Atlassian JIRA
(v6.2#6252)