[asterisk-bugs] [JIRA] (ASTERISK-25217) [patch]res_pjsip_outbound_publish.c needs a similar treatment for module unloading as res_pjsip_outbound_registration.c

[Joshua Colp (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-25217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joshua Colp closed ASTERISK-25217.
----------------------------------

    Resolution: Fixed

> [patch]res_pjsip_outbound_publish.c needs a similar treatment for module unloading as res_pjsip_outbound_registration.c
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-25217
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25217
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip_outbound_publish
>    Affects Versions: 13.4.0
>            Reporter: Richard Mudgett
>         Attachments: jira_asterisk_25217_v13_attempted_fix.patch
>
>
> ASTERISK-24907 fixed a crash on module unloading for {{res_pjsip_outbound_registration}}.  A similar treatment needs to be performed to {{res_pjsip_outbound_publish}} to make it safer to unload.
> # The module needs to use {{ast_sorcery_object_unregister()}}.
> # The module needs to use its own serializers so it can do a group shutdown on them.  {{ast_serializer_shutdown_group_join()}}  The {{struct unloading_data}} method used in the module is not reliable as the threads may not get out of the module before it gets unloaded.  See the ASTERISK-24514 fix {{664067e3189b29bd00276725d2293363c9b9ebe1}}.
> # There is a bug in the module's {{unload_module()}} dealing with the return value of {{ast_cond_timedwait()}}.  The attached patch is an attempted fix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)