[asterisk-bugs] [JIRA] (ASTERISK-26061) [patch] res_pjsip: improve realtime performance - remove updating all endpoints status on startup

[nappsoft (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-26061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=231727#comment-231727 ] 

nappsoft edited comment on ASTERISK-26061 at 8/4/16 6:10 AM:
-------------------------------------------------------------

Just discovered a problem with asterisk-13.11.0-rc1 related to this change:

After startup the State for all hints that have no registered contact is "Idle" instead of "Unavailable" and will stay like this until a contact registers.

Applying the patch (which reverts some of the changes) fixes the issue (what might not be the idea behind the original patch indeed, but I only wanted to check where the issue comes from). The important change is the second changeset I guess (I only made the change of the first changeset as I'm not sure why the "if (status)" had been removed...).

Please note that I've observed another strange behavior: two of the aors with no registered contact changed to the right status after a while (the other nine didn't)! The only difference between these aors and the others is that these two aors have a name that is similar to the one of a aor with a registered contact: the one with the registered contact is called "snom", the others are called "snomprov" and "snomd375". So as you can see the name of the aor with a registered contact is a substring of the name of the other two aors... Is there a problem with some contact/aor matching functions somewhere in the code?


was (Author: nappsoft):
Just discovered a problem with asterisk-13.11.0-rc1 related to this change:

After startup the State for all hints that have no registered contact is "Idle" instead of "Unavailable" and will stay like this until a contact registers.

Applying the patch (which reverts some of the changes) fixes the issue (what might not be the idea of the original patch indeed, but I only wanted to check where the issue comes from). The important change is the second changeset I guess (I only made the change of the first changeset as I'm not sure why the "if (status)" had been removed...).

Please note that I've observed another strange behavior: two of the aors with no registered contact changed to the right status after a while (the other nine didn't)! The only difference between these aors and the others is that these two aors have a name that is similar to the one of a aor with a registered contact: the one with the registered contact is called "snom", the others are called "snomprov" and "snomd375". So as you can see the name of the aor with a registered contact is a substring of the name of the other two aors... Is there a problem with some contact/aor matching functions somewhere in the code?

> [patch] res_pjsip: improve realtime performance - remove updating all endpoints status on startup
> -------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-26061
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26061
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip
>    Affects Versions: 13.9.1
>            Reporter: Alexei Gradinari
>         Attachments: ast13.diff
>
>
> The patch removes updating all Endpoints' status on startup.
> Instead, only non-qualified aors with static contact
> and non-qualified non-expired contacts are retrieved from the realtime to
> update the endpoint status to ONLINE.
> The endpoint name was added to the contact object to simply find the endpoint
> that created this contact.
> The status of endpoints with qualified aors will be updated by 'qualify'
> functions.



--
This message was sent by Atlassian JIRA
(v6.2#6252)