[asterisk-bugs] [JIRA] (ASTERISK-26255) Fix includes of sys/signal.h

[Asterisk Team (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-26255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=231662#comment-231662 ] 

Asterisk Team commented on ASTERISK-26255:
------------------------------------------

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

> Fix includes of sys/signal.h
> ----------------------------
>
>                 Key: ASTERISK-26255
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-26255
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Core/Portability
>    Affects Versions: 13.10.0, 14.0.0-beta1
>         Environment: musl libc 1.1.14, gcc 5.3, x86_64
>            Reporter: Seamus Caveney
>            Severity: Trivial
>
> Numerous files include <sys/signal.h> incorrectly, the proper include across all platforms should just be <signal.h>. Modern revisions of glibc silently redirect <sys/signal.h> to <signal.h>, while musl does output a warning:
> #warning redirecting incorrect #include <sys/signal.h> to <signal.h>
> The patch replaces all occurrences of <sys/signal.h> with <signal.h>. Additionally there were a few locations with preprocessor checks that were made redundant:
> - apps/app_dahdiras.c - removed __linux__ check
> - channels/chan_dahdi.c - removed __NetBSD__ || __FreeBSD__ check
> - pbx/pbx_dundi.c - moved signal.h and ifaddrs.h includes outside of BSD/OSX as they are not platform specific
> If the ifaddrs.h related modification should be split into another issue ticket, please let me know.
> I will be submitting the patch to Gerrit momentarily 



--
This message was sent by Atlassian JIRA
(v6.2#6252)