[asterisk-bugs] [JIRA] (ASTERISK-25917) [patch]app_voicemail: passwordlocation=spooldir only works if you manually add secret.conf yourself

[Jonathan R. Rose (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=230307#comment-230307 ] 

Jonathan R. Rose commented on ASTERISK-25917:
---------------------------------------------

Regression was introduced by

commit 2fbdeafb19b52165f778f238589d34d60d693081
Author: George Joseph <george.joseph at fairview5.com>
Date:   Wed Sep 10 16:01:44 2014 +0000

    config: bug: fix truncation of included config files on permissions error
    
    ast_config_text_file_save() currently truncates include files as they
    are processed.  If a subsequent include file or the main config file has
    a permissions error that prevents writing, earlier include files are left
    truncated resulting in a frantic search for backups.
    
    This patch causes ast_config_text_file_save to check for write access
    on all files before it truncates any of them.
    
    Will be applied 1.8 > trunk.
    
    Tested by: George Joseph
    Review: https://reviewboard.asterisk.org/r/3986/
    ........
    
    Merged revisions 422900 from http://svn.asterisk.org/svn/asterisk/branches/1.8
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@422903 65c4cc65-6c06-0410-ace0-fbb531ad65f3


> [patch]app_voicemail: passwordlocation=spooldir only works if you manually add secret.conf yourself
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-25917
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25917
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_voicemail
>    Affects Versions: 11.22.0-rc1, 13.8.0-rc1
>            Reporter: Jonathan R. Rose
>         Attachments: asterisk_write_new_config.diff
>
>
> Long time no patch.
> passwordlocation=spooldir is a general section option in voicemail.conf that makes changed voicemail passwords be stored in a secret.conf file within the individual mailbox folders rather than writing the change directly to voicemail.conf
> I tracked this feature back to 1.8 which is the first version where it was implemented. It doesn't work in the final version of 1.8 or in any version since because ast_config_text_file_save won't write new files. It exits early on account of failing an access check against the file that doesn't exist yet.
> I've written a very simple patch against Asterisk 11 that just adds a check for when the file doesn't exist and skips the check against read and write access check if that's the case. I'll be attaching the patch to the issue, and hopefully my new contributor agreement will be authorized soon.



--
This message was sent by Atlassian JIRA
(v6.2#6252)