[asterisk-bugs] [JIRA] (ASTERISK-25917) [patch]app_voicemail: passwordlocation=spooldir only works if you manually add secret.conf yourself

[Jonathan R. Rose (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=230306#comment-230306 ] 

Jonathan R. Rose edited comment on ASTERISK-25917 at 4/19/16 12:31 PM:
-----------------------------------------------------------------------

Oh hey, some more information on this issue... these access checks aren't in 11.6-cert13, so this is actually a regression. At the same time, I assume this change was made for a reason, so there's a good chance that my patch isn't the best answer to this problem. It might actually be more prudent to add the ability to write new files as an option to the config.h function being used here.

Since it turned out to be a regression, I've bumped the severity to major.


was (Author: jonathanrose):
Oh hey, some more information on this issue... these access checks aren't in 11.6-cert13, so this is actually a regression. At the same time, I assume this change was made for a reason, so there's a good chance that my patch isn't the best answer to this problem.

Since it turned out to be a regression, I've bumped the severity to major.

> [patch]app_voicemail: passwordlocation=spooldir only works if you manually add secret.conf yourself
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-25917
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25917
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_voicemail
>    Affects Versions: 11.22.0-rc1, 13.8.0-rc1
>            Reporter: Jonathan R. Rose
>         Attachments: asterisk_write_new_config.diff
>
>
> Long time no patch.
> passwordlocation=spooldir is a general section option in voicemail.conf that makes changed voicemail passwords be stored in a secret.conf file within the individual mailbox folders rather than writing the change directly to voicemail.conf
> I tracked this feature back to 1.8 which is the first version where it was implemented. It doesn't work in the final version of 1.8 or in any version since because ast_config_text_file_save won't write new files. It exits early on account of failing an access check against the file that doesn't exist yet.
> I've written a very simple patch against Asterisk 11 that just adds a check for when the file doesn't exist and skips the check against read and write access check if that's the case. I'll be attaching the patch to the issue, and hopefully my new contributor agreement will be authorized soon.



--
This message was sent by Atlassian JIRA
(v6.2#6252)